Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr/dashboard: fix server side encryption config error #49173

Merged
merged 1 commit into from Dec 16, 2022

Conversation

aaSharma14
Copy link
Contributor

@aaSharma14 aaSharma14 commented Dec 1, 2022

After setting SSE-S3 values from dashboard, it throws 500 error and also it sets the config values to incorrect RGW processes. This PR intends to fix this issue.

Fixes: https://tracker.ceph.com/issues/58296
Signed-off-by: Aashish Sharma aasharma@redhat.com

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@aaSharma14 aaSharma14 requested a review from a team as a code owner December 1, 2022 10:38
@aaSharma14 aaSharma14 added this to In progress in Dashboard via automation Dec 1, 2022
@github-actions github-actions bot added the pybind label Dec 1, 2022
Copy link
Contributor

@avanthakkar avanthakkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some unit-test to check this behavior? @aaSharma14

@aaSharma14
Copy link
Contributor Author

jenkins test make check

Dashboard automation moved this from In progress to Reviewer approved Dec 7, 2022
@avanthakkar
Copy link
Contributor

jenkins test make check arm64

@avanthakkar
Copy link
Contributor

jenkins test windows

@avanthakkar avanthakkar moved this from Reviewer approved to Ready-to-merge in Dashboard Dec 14, 2022
Fixes: https://tracker.ceph.com/issues/58296
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
@aaSharma14 aaSharma14 merged commit f2bb489 into ceph:main Dec 16, 2022
9 of 14 checks passed
Dashboard automation moved this from Ready-to-merge to Done Dec 16, 2022
@aaSharma14 aaSharma14 deleted the fix-encryption-config branch December 16, 2022 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Dashboard
  
Done
3 participants