Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quincy: osd: Reset mClock's OSD capacity config option for inactive device type #49281

Merged
merged 1 commit into from Feb 16, 2023
Merged

quincy: osd: Reset mClock's OSD capacity config option for inactive device type #49281

merged 1 commit into from Feb 16, 2023

Conversation

sseshasa
Copy link
Contributor

@sseshasa sseshasa commented Dec 6, 2022

backport tracker: https://tracker.ceph.com/issues/58186

backport of #48708
parent tracker: https://tracker.ceph.com/issues/57963

this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh

@sseshasa
osd: Reset mClock's OSD capacity config option for inactive device type
fb2ad2d 
Depending on the underlying device type of an OSD, the mClock's OSD
capacity option of either osd_mclock_max_capacity_iops_hdd or
osd_mclock_max_capacity_iops_ssd is set during OSD boot-up. Both the
options have built-in defaults set. Therefore, when displaying the running
configuration of an OSD, both the values would be displayed with non-zero
values which could confuse/mislead a user.

To address this, override the inactive device type's capacity for the OSD
to '0'.

For e.g., with this change, if the underlying device type for an OSD is
an ssd, the cli displays the running configuration of
osd_mclock_max_capacity_iops_hdd for that OSD as '0' instead of it's
default value.

Fixes: https://tracker.ceph.com/issues/57963
Signed-off-by: Sridhar Seshasayee <sseshasa@redhat.com>
(cherry picked from commit a0781c7)
@sseshasa sseshasa requested a review from a team as a code owner December 6, 2022 11:53
@sseshasa sseshasa added this to the quincy milestone Dec 6, 2022
@sseshasa sseshasa added the core label Dec 6, 2022
@sseshasa
Copy link
Contributor Author

sseshasa commented Dec 7, 2022

jenkins test make check

@ljflores
Copy link
Contributor

Rados suite review: http://pulpito.front.sepia.ceph.com/?branch=wip-yuri-testing-2023-02-06-1155-quincy

Failures, unrelated:
1. https://tracker.ceph.com/issues/58146
2. https://tracker.ceph.com/issues/58046 -- pending quincy backport
3. https://tracker.ceph.com/issues/56788
4. https://tracker.ceph.com/issues/58739
5. https://tracker.ceph.com/issues/58560
6. https://tracker.ceph.com/issues/58585

Details:
1. test_cephadm.sh: Error: Error initializing source docker://quay.ceph.io/ceph-ci/ceph:master - Ceph - Orchestrator
2. qa/workunits/rados/test_librados_build.sh: specify redirect in curl command - Ceph - RADOS
3. crash: void KernelDevice::_aio_thread(): abort - Ceph - Bluestore
4. "Leak_IndirectlyLost" valgrind report on mon.a - Ceph - RADOS
5. test_envlibrados_for_rocksdb.sh failed to subscrib repo - Ceph - RADOS
6. rook: failed to pull kubelet image - Ceph - Orchestrator

@ljflores
Copy link
Contributor

jenkins test make check

@yuriw yuriw merged commit 3641507 into ceph:quincy Feb 16, 2023
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neha-ojha neha-ojha neha-ojha approved these changes

@ljflores ljflores Awaiting requested review from ljflores

Assignees
No one assigned
Labels
core needs-qa wip-yuri-testing
Projects
None yet
Milestone
quincy
4 participants
@sseshasa @ljflores @neha-ojha @yuriw