Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr/dashboard: allow Origin url for CORS if present in config #49329

Merged
merged 1 commit into from Dec 13, 2022

Conversation

avanthakkar
Copy link
Contributor

@avanthakkar avanthakkar commented Dec 8, 2022

By default the browser will not set Access-Control-Allow-Origin header in Request headers. So allow the CORS for the origins which uses browser to access the url and are mentioned in config key cross_origin_url.

Fixes: https://tracker.ceph.com/issues/58245
Signed-off-by: Avan Thakkar athakkar@redhat.com

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@avanthakkar avanthakkar changed the title mgr/dashboard: allow Origin for CORS if present in config `cross_orig… mgr/dashboard: allow Origin for CORS if present url in config Dec 8, 2022
@avanthakkar avanthakkar changed the title mgr/dashboard: allow Origin for CORS if present url in config mgr/dashboard: allow Origin url for CORS if present in config Dec 8, 2022
…in_url`

Signed-off-by: Avan Thakkar <athakkar@redhat.com>
@tchaikov
Copy link
Contributor

tchaikov commented Dec 9, 2022

jenkins test make check

@avanthakkar avanthakkar marked this pull request as ready for review December 12, 2022 07:24
@avanthakkar avanthakkar requested a review from a team as a code owner December 12, 2022 07:24
@avanthakkar avanthakkar requested review from pereman2 and removed request for a team December 12, 2022 07:24
@avanthakkar
Copy link
Contributor Author

jenkins test dashboard cephadm

@avanthakkar
Copy link
Contributor Author

jenkins test dashboard

@avanthakkar
Copy link
Contributor Author

jenkins test make check arm64

@avanthakkar
Copy link
Contributor Author

jenkins test windows

@avanthakkar
Copy link
Contributor Author

jenkins test dashboard cephadm

@avanthakkar
Copy link
Contributor Author

e2e failures aren't related to the PR. Proceeding with merging PR.

@avanthakkar avanthakkar merged commit fed4c25 into ceph:main Dec 13, 2022
13 of 19 checks passed
@avanthakkar avanthakkar deleted the fix-cors branch December 13, 2022 07:12
@nizamial09 nizamial09 restored the fix-cors branch December 14, 2022 11:40
@nizamial09 nizamial09 deleted the fix-cors branch December 14, 2022 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
4 participants