mgr/dashboard: Fix rbd snapshot creation

[aaSharma14]

There are two types of snapshots that can be created on a snapshot based mirroring image - Normal Snapshot(same as journal based snapshot) and Mirror Image Snapshot. Till now Dashboard allowed only Mirror image snapshot, this PR intends to enable both the types

Contribution Guidelines

• To sign and title your commits, please refer to Submitting Patches to Ceph.

• If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

Checklist

• Tracker (select at least one)
  • References tracker ticket
  • Very recent bug; references commit where it was introduced
  • New feature (ticket optional)
  • Doc update (no ticket needed)
  • Code cleanup (no ticket needed)
• Component impact
  • Affects Dashboard, opened tracker ticket
  • Affects Orchestrator, opened tracker ticket
  • No impact that needs to be tracked
• Documentation (select at least one)
  • Updates relevant documentation
  • No doc update is appropriate
• Tests (select at least one)
  • Includes unit test(s)
  • Includes integration test(s)
  • Includes bug reproducer
  • No tests

Show available Jenkins commands

• jenkins retest this please
• jenkins test classic perf
• jenkins test crimson perf
• jenkins test signed
• jenkins test make check
• jenkins test make check arm64
• jenkins test submodules
• jenkins test dashboard
• jenkins test dashboard cephadm
• jenkins test api
• jenkins test docs
• jenkins render docs
• jenkins test ceph-volume all
• jenkins test ceph-volume tox
• jenkins test windows

[nizamial09]

some minor suggestions. if you want you can take that as an improvment lateron, but please make sure to have a tracker on that.

[sunilangadi2]

@aaSharma14 can you please point me to that docs link for these types of snapshot creation?

[aaSharma14]

@aaSharma14 can you please point me to that docs link for these types of snapshot creation?

@sunilangadi2 , I hope you are aware of the normal snapshot creation with command - rbd snap create.., the second one is mentioned here - https://docs.ceph.com/en/quincy/rbd/rbd-mirroring/#create-image-mirror-snapshots

[aaSharma14]

jenkins test dashboard

[sunilangadi2]

@aaSharma14 can you please point me to that docs link for these types of snapshot creation?

@sunilangadi2 , I hope you are aware of the normal snapshot creation with command - rbd snap create.., the second one is mentioned here - https://docs.ceph.com/en/quincy/rbd/rbd-mirroring/#create-image-mirror-snapshots

@aaSharma14 Thanks for the link, If image is already snapshot based mirrored what is the point of creating normal snapshots to it?

[VasishtaShastry]

@sunilangadi2 : hanks for the link, If image is already snapshot based mirrored what is the point of creating normal snapshots to it?

Regular image snapshot is a currently bigger feature which supports layering of images

[nizamial09]

jenkins retest this please

[nizamial09]

lint failure

CHAR-0x1B][0m: [NON-XML-CHAR-0x1B][1;31mE501[NON-XML-CHAR-0x1B][0m line too long (102 > 100 characters)
1     E501 line too long (102 > 100 characters)
lint: exit 1 (1.60 seconds) /home/jenkins-build/build/workspace/ceph-pull-requests/src/pybind/mgr/dashboard> flake8 --config=tox.ini ../../../../qa/tasks/mgr/dashboard pid=3980861
  lint: FAIL code 1 (33.12=setup[28.14]+cmd[3.39,1.60] seconds)
  evaluation failed :( (33.22 seconds)

[aaSharma14]

jenkins test make check