New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd: cache full mode still skips young objects #5051

Merged
2 commits merged into from Jul 24, 2015

Conversation

Projects
None yet
5 participants
@smithfarm
Contributor

smithfarm commented Jun 22, 2015

wonzhq and others added some commits Aug 1, 2014

osd: add local_mtime to struct object_info_t
This fixes a bug when the time of the OSDs and clients are not
synchronized (especially when client is ahead of OSD), and the cache
tier dirty ratio reaches the threshold, the agent skips the flush work
because it thinks the object is too young.

Signed-off-by: Zhiqiang Wang <wonzhq@hotmail.com>
(cherry picked from commit 13b9dc7)
osd: cache pool: flush object ignoring cache min flush age when cache…
… pool is full

Signed-off-by: Xinze Chi <xmdxcxz@gmail.com>

(cherry picked from commit f4ee949)

@smithfarm smithfarm added this to the firefly milestone Jun 22, 2015

@ghost ghost changed the title from osd cache full mode still skips young objects to osd: cache full mode still skips young objects Jul 21, 2015

@ghost

This comment has been minimized.

ghost commented Jul 21, 2015

9969ae5 comes from #2188 and 3f2fb8a comes from #2856 both of which were merged by sage who is the ultimate authority on tiering. Tiering changed a lot since firefly and the odds of this backport being incorrect or improperly tested are high, therefore it is best to ask for sage approval.

@ghost ghost assigned liewegas Jul 21, 2015

@ghost

This comment has been minimized.

ghost commented Jul 21, 2015

@liewegas this backport passed a rados suite ( http://pulpito.ceph.com/loic-2015-07-09_21:09:04-rados-firefly-backports---basic-multi ), do you think it can be merged in firefly ?

@liewegas

This comment has been minimized.

Member

liewegas commented Jul 21, 2015

yeah, i think this is safe.

ghost pushed a commit that referenced this pull request Jul 24, 2015

Loic Dachary
Merge pull request #5051 from SUSE/wip-12016-firefly
osd: cache full mode still skips young objects

Reviewed-by: Sage Weil <sage@redhat.com>

@ghost ghost merged commit 57bbc8e into ceph:firefly Jul 24, 2015

@smithfarm smithfarm deleted the SUSE:wip-12016-firefly branch Jul 24, 2015

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment