ceph-volume: quick fix in zap.py #50745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guits
force-pushed
the
quick-fix-cv
branch
2 times, most recently
from
cf90ee4
to
c86f13e
Compare
adk3798
approved these changes
Apr 12, 2023
`api.get_single_pv(filters={'lv_uuid': lv.lv_uuid})` needs to be called
only if `--destroy` is passed in order to remove vg and pv when there's
nothing left.
With old deployments, it is possible that a lv_uuid matches more than 1
PV.
Given that `get_single_pv()` is only needed when `--destroy` is passed,
let's move this call where it is actually needed.
This makes `ceph-volume lvm zap` fail even though
Fixes: https://tracker.ceph.com/issues/59210
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
|
Reruns of all but upgrade-with-workload jobs (which are known to timeout after multiple hours currently, so reruns would waste a lot of resources): https://pulpito.ceph.com/adking-2023-04-22_17:05:01-orch:cephadm-wip-adk-testing-2023-04-20-0105-distro-default-smithi/ After reruns, 2 dead and 5 failed jobs:
|
This was referenced Apr 24, 2023
yuvalif
pushed a commit
to yuvalif/ceph
that referenced
this pull request
Apr 30, 2023
ceph-volume: quick fix in zap.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
api.get_single_pv(filters={'lv_uuid': lv.lv_uuid})needs to be called only if--destroyis passed in order to remove vg and pv when there's nothing left.With old deployments, it is possible that a lv_uuid matches more than 1 PV.
Given that
get_single_pv()is only needed when--destroyis passed, let's move this call where it is actually needed.This makes
ceph-volume lvm zapfail even thoughFixes: https://tracker.ceph.com/issues/59210