Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr/dashboard: fix create osd default selected as recommended not working #50867

Merged
merged 2 commits into from
Apr 11, 2023

Conversation

nizamial09
Copy link
Member

Also added a skip option to skip the create OSDs step if needed.

Screenshot from 2023-04-05 12-03-23

Fixes: https://tracker.ceph.com/issues/59319

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@nizamial09 nizamial09 requested a review from a team as a code owner April 5, 2023 06:39
@nizamial09 nizamial09 requested review from avanthakkar and pereman2 and removed request for a team April 5, 2023 06:39
@nizamial09
Copy link
Member Author

jenkins test dashboard

@nizamial09
Copy link
Member Author

jenkins test dashboard cephadm

@nizamial09 nizamial09 changed the title mgr/dashboard: fix create osd default selected as recommended not working mgr/dashboard: fix create osd default selected as recommended not working Apr 5, 2023
@nizamial09
Copy link
Member Author

jenkins test dashboard

@nizamial09
Copy link
Member Author

jenkins test dashboard cephadm

the backend was reporting with a keyError which doesn't find the
`encrypted` key.

Fixes: https://tracker.ceph.com/issues/59319
Signed-off-by: Nizamudeen A <nia@redhat.com>
@nizamial09 nizamial09 merged commit 018cd41 into ceph:main Apr 11, 2023
2 of 3 checks passed
@nizamial09 nizamial09 deleted the skip-osds-expand-cluster branch April 11, 2023 05:20
yuvalif pushed a commit to yuvalif/ceph that referenced this pull request Apr 30, 2023
…uster

mgr/dashboard: fix create osd default selected as recommended not working 

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants