Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mgr/dashboard: hide notification on force promote #51163

Merged
merged 1 commit into from Apr 20, 2023
Merged

mgr/dashboard: hide notification on force promote #51163

merged 1 commit into from Apr 20, 2023

Conversation

Pegonzal
Copy link
Contributor

@Pegonzal Pegonzal commented Apr 20, 2023 •
edited

Fixes: https://tracker.ceph.com/issues/59500
Signed-off-by: Pedro Gonzalez Gomez pegonzal@redhat.com

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@Pegonzal
mgr/dashboard: hide notification on force promote
abe1e51 
Fixes: https://tracker.ceph.com/issues/59500
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
@Pegonzal Pegonzal requested a review from a team as a code owner April 20, 2023 15:32
@Pegonzal Pegonzal requested review from avanthakkar and nizamial09 and removed request for a team April 20, 2023 15:32
@nizamial09 nizamial09 merged commit d36d554 into ceph:main Apr 20, 2023
10 of 13 checks passed
@nizamial09 nizamial09 deleted the hide-rbd-force-promote-notification branch April 20, 2023 17:35
This was referenced Apr 20, 2023
Merged
Merged
yuvalif pushed a commit to yuvalif/ceph that referenced this pull request Apr 30, 2023
@nizamial09 @yuvalif
Merge pull request ceph#51163 from rhcs-dashboard/hide-rbd-force-prom…
5a6991d 
…ote-notification

mgr/dashboard: hide notification on force promote

Reviewed-by: Nizamudeen A <nia@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nizamial09 nizamial09 nizamial09 approved these changes

@avanthakkar avanthakkar Awaiting requested review from avanthakkar avanthakkar is a code owner automatically assigned from ceph/dashboard

Assignees
No one assigned
Labels
dashboard pybind
Projects
None yet
Milestone
No milestone
2 participants
@Pegonzal @nizamial09