New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fs: cephfs Dumper tries to load whole journal into memory at once #5120

Merged
1 commit merged into from Jul 30, 2015

Conversation

Projects
None yet
3 participants
@theanalyst
Member

theanalyst commented Jul 1, 2015

tools: chunk reads in Dumper
Previously tried to read entire journal
into memory in one go, which was problematic
for large journals.

Fixes: #11746
Signed-off-by: John Spray <john.spray@redhat.com>
(cherry picked from commit e3ddcb8)

@theanalyst theanalyst self-assigned this Jul 1, 2015

@theanalyst theanalyst added this to the hammer milestone Jul 1, 2015

@theanalyst theanalyst added bug fix core cephfs and removed core labels Jul 1, 2015

ghost pushed a commit that referenced this pull request Jul 15, 2015

Merge pull request #5120: cephfs Dumper tries to load whole journal i…
…nto memory at once

Reviewed-by: Loic Dachary <ldachary@redhat.com>

ghost pushed a commit that referenced this pull request Jul 15, 2015

Merge pull request #5120: cephfs Dumper tries to load whole journal i…
…nto memory at once

Reviewed-by: Loic Dachary <ldachary@redhat.com>

ghost pushed a commit that referenced this pull request Jul 16, 2015

Merge pull request #5120: cephfs Dumper tries to load whole journal i…
…nto memory at once

Reviewed-by: Loic Dachary <ldachary@redhat.com>

ghost pushed a commit that referenced this pull request Jul 19, 2015

Merge pull request #5120: cephfs Dumper tries to load whole journal i…
…nto memory at once

Reviewed-by: Loic Dachary <ldachary@redhat.com>

ghost pushed a commit that referenced this pull request Jul 19, 2015

Merge pull request #5120: cephfs Dumper tries to load whole journal i…
…nto memory at once

Reviewed-by: Loic Dachary <ldachary@redhat.com>

ghost pushed a commit that referenced this pull request Jul 19, 2015

Merge pull request #5120: cephfs Dumper tries to load whole journal i…
…nto memory at once

Reviewed-by: Loic Dachary <ldachary@redhat.com>

ghost pushed a commit that referenced this pull request Jul 19, 2015

Merge pull request #5120: cephfs Dumper tries to load whole journal i…
…nto memory at once

Reviewed-by: Loic Dachary <ldachary@redhat.com>

ghost pushed a commit that referenced this pull request Jul 19, 2015

Merge pull request #5120: cephfs Dumper tries to load whole journal i…
…nto memory at once

Reviewed-by: Loic Dachary <ldachary@redhat.com>
@ghost

This comment has been minimized.

ghost commented Jul 28, 2015

@gregsfortytwo does this hammer backport looks good to merge ? It went through a fs suite ( http://tracker.ceph.com/issues/11990#fs ).

ghost pushed a commit that referenced this pull request Jul 29, 2015

@gregsfortytwo

This comment has been minimized.

Member

gregsfortytwo commented Jul 30, 2015

LGTM

ghost pushed a commit that referenced this pull request Jul 30, 2015

Loic Dachary
Merge pull request #5120 from theanalyst/wip-11999-hammer
cephfs Dumper tries to load whole journal into memory at once

Reviewed-by: Greg Farnum <gfarnum@redhat.com>

@ghost ghost merged commit a48cbc0 into ceph:hammer Jul 30, 2015

@ghost ghost changed the title from cephfs Dumper tries to load whole journal into memory at once to fs: cephfs Dumper tries to load whole journal into memory at once Aug 4, 2015

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment