New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd: FAILED assert(!old_value.deleted()) in upgrade:giant-x-hammer-distro-basic-multi run #5121

Merged
merged 2 commits into from Jul 31, 2015

Conversation

Projects
None yet
4 participants
@theanalyst
Member

theanalyst commented Jul 1, 2015

athanatos added some commits Apr 1, 2015

ReplicatedPG::finish_promote: fix snap promote head snaps
If the snaps vector is: 10=[9,5,2]:[4]+head, the backing pool's snaps
vector is 3=[2]:[]+head, and we request clone 4 from the backing pool,
the backing pool will send us head with an empty results->snaps vector.
Actually, clone 4 should be trimmed, but the cache pool does not know
that.  Thus, we should construct an empty snaps vector for that clone.

PartialFix: #11296
Backport: firefly, hammer
Signed-off-by: Samuel Just <sjust@redhat.com>
(cherry picked from commit a45a698)
ReplicatedPG::finish_promote: handle results->snaps is empty case
If results->snaps winds up empty after filtering removed snaps,
we need to treat the object as if we had gotten an ENOENT.

PartialFix: #11296
Backport: firefly, hammer
Signed-off-by: Samuel Just <sjust@redhat.com>
(cherry picked from commit 6150757)

@theanalyst theanalyst self-assigned this Jul 1, 2015

@theanalyst theanalyst added this to the hammer milestone Jul 1, 2015

ghost pushed a commit that referenced this pull request Jul 15, 2015

Merge pull request #5121: FAILED assert(!old_value.deleted()) in upgr…
…ade:giant-x-hammer-distro-basic-multi run

Reviewed-by: Loic Dachary <ldachary@redhat.com>

ghost pushed a commit that referenced this pull request Jul 15, 2015

Merge pull request #5121: FAILED assert(!old_value.deleted()) in upgr…
…ade:giant-x-hammer-distro-basic-multi run

Reviewed-by: Loic Dachary <ldachary@redhat.com>

ghost pushed a commit that referenced this pull request Jul 16, 2015

Merge pull request #5121: FAILED assert(!old_value.deleted()) in upgr…
…ade:giant-x-hammer-distro-basic-multi run

Reviewed-by: Loic Dachary <ldachary@redhat.com>

ghost pushed a commit that referenced this pull request Jul 19, 2015

Merge pull request #5121: FAILED assert(!old_value.deleted()) in upgr…
…ade:giant-x-hammer-distro-basic-multi run

Reviewed-by: Loic Dachary <ldachary@redhat.com>

ghost pushed a commit that referenced this pull request Jul 19, 2015

Merge pull request #5121: FAILED assert(!old_value.deleted()) in upgr…
…ade:giant-x-hammer-distro-basic-multi run

Reviewed-by: Loic Dachary <ldachary@redhat.com>

ghost pushed a commit that referenced this pull request Jul 19, 2015

Merge pull request #5121: FAILED assert(!old_value.deleted()) in upgr…
…ade:giant-x-hammer-distro-basic-multi run

Reviewed-by: Loic Dachary <ldachary@redhat.com>

ghost pushed a commit that referenced this pull request Jul 19, 2015

Merge pull request #5121: FAILED assert(!old_value.deleted()) in upgr…
…ade:giant-x-hammer-distro-basic-multi run

Reviewed-by: Loic Dachary <ldachary@redhat.com>

ghost pushed a commit that referenced this pull request Jul 19, 2015

Merge pull request #5121: FAILED assert(!old_value.deleted()) in upgr…
…ade:giant-x-hammer-distro-basic-multi run

Reviewed-by: Loic Dachary <ldachary@redhat.com>
@ghost

This comment has been minimized.

ghost commented Jul 28, 2015

@liewegas does this hammer backport looks good to merge ? It went through a rados suite ( http://tracker.ceph.com/issues/11990#rados ). There was a transient error ( http://tracker.ceph.com/issues/12469 ) but I don't think it's related.

ghost pushed a commit that referenced this pull request Jul 29, 2015

Merge pull request #5121: FAILED assert(!old_value.deleted()) in upgr…
…ade:giant-x-hammer-distro-basic-multi run

Reviewed-by:
@ghost

This comment has been minimized.

ghost commented Jul 31, 2015

@liewegas ping ?

liewegas added a commit that referenced this pull request Jul 31, 2015

Merge pull request #5121 from theanalyst/wip-11983-hammer
FAILED assert(!old_value.deleted()) in upgrade:giant-x-hammer-distro-basic-multi run

Reviewed-by: Sage Weil <sage@redhat.com>

@liewegas liewegas merged commit 78a4024 into ceph:hammer Jul 31, 2015

@ghost ghost changed the title from FAILED assert(!old_value.deleted()) in upgrade:giant-x-hammer-distro-basic-multi run to osd: FAILED assert(!old_value.deleted()) in upgrade:giant-x-hammer-distro-basic-multi run Aug 4, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment