rgw/multisite[archive zone]: fix storing of bucket instance info in the new bucket entrypoint

[smanjara]

The new bucket instance on archive zone was being inaccessible after deleting source bucket. Fixed by copying the old bucket instance info into the new entrypoint.

Fixes: https://tracker.ceph.com/issues/43221

Contribution Guidelines

• To sign and title your commits, please refer to Submitting Patches to Ceph.

• If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

Checklist

• Tracker (select at least one)
  • References tracker ticket
  • Very recent bug; references commit where it was introduced
  • New feature (ticket optional)
  • Doc update (no ticket needed)
  • Code cleanup (no ticket needed)
• Component impact
  • Affects Dashboard, opened tracker ticket
  • Affects Orchestrator, opened tracker ticket
  • No impact that needs to be tracked
• Documentation (select at least one)
  • Updates relevant documentation
  • No doc update is appropriate
• Tests (select at least one)
  • Includes unit test(s)
  • Includes integration test(s)
  • Includes bug reproducer
  • No tests

Show available Jenkins commands

• jenkins retest this please
• jenkins test classic perf
• jenkins test crimson perf
• jenkins test signed
• jenkins test make check
• jenkins test make check arm64
• jenkins test submodules
• jenkins test dashboard
• jenkins test dashboard cephadm
• jenkins test api
• jenkins test docs
• jenkins render docs
• jenkins test ceph-volume all
• jenkins test ceph-volume tox
• jenkins test windows

[cbodley]

just above, there's a block comment about why this workaround is necessary - to keep the list of user.buckets consistent. can we verify that the renamed bucket is still visible under it's owning user with radosgw-admin bucket list --uid=?

[cbodley]

so we were updating the existing bucket instance metadata, then deleting it with remove_bucket_instance_info() just below? neither store_bucket_instance_info() nor remove_bucket_instance_info() delete the bucket index objects, but this removal of the bucket instance metadata would effectively orphan the bucket index shards and all of the object versions they contained

[smanjara]

since we are only renaming the bucket, is it necessary to clean the bucket index shards?
I can list the objects and do all sorts of get bucket operations on this renamed bucket.

[cbodley]

is it necessary to clean the bucket index shards?

no. you're right, we still need the index

[smanjara]

just above, there's a block comment about why this workaround is necessary - to keep the list of user.buckets consistent. can we verify that the renamed bucket is still visible under it's owning user with radosgw-admin bucket list --uid=?

@cbodley yes, I verified this and I can list the renamed bucket under the user.

[smanjara]

$radosgw-admin bucket list --uid=testuser

[
    "test-bucket-deleted-3d37706f8173d983c756d5d108af96f2"
]

$radosgw-admin bucket list --bucket test-bucket-deleted-3d37706f8173d983c756d5d108af96f2

[
    {
        "name": "ceph.conf",
        "instance": "b5X.XXi0D8zk68IIVvnTJWOqmN63SII",
        "ver": {
            "pool": 6,
            "epoch": 1
        },
        "locator": "",
        "exists": true,
        "meta": {
            "category": 1,
            "size": 5638,
            "mtime": "2023-04-27T20:40:17.968148Z",
            "etag": "7342e8d2b50d53ce8d499c9c0a596598",
            "storage_class": "STANDARD",
            "owner": "testuser",
            "owner_display_name": "testuser",
            "content_type": "text/plain",
            "accounted_size": 5638,
            "user_data": "",
            "appendable": false
        },
        "tag": "_2Xc-iJ_RAtrgKMzp4HYxepI2b9sZiJL",
        "flags": 3,
        "pending_map": [],
        "versioned_epoch": 2
    }
]

[cbodley]

jenkins test make check

[cbodley]

jenkins test make check

[cbodley]

passed qa after rerun https://pulpito.ceph.com/cbodley-2023-05-25_13:09:32-rgw-wip-cbodley-testing-distro-default-smithi/