Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr/dashboard: fix regression caused by cephPgImabalance alert #51385

Merged
merged 1 commit into from May 16, 2023

Conversation

aaSharma14
Copy link
Contributor

@aaSharma14 aaSharma14 commented May 8, 2023

Because of an earlier fix delivered for cephPgImbalance Alert(#51189), there is a regression caused by it due to which alerts are not getting displayed in the active alerts tab. This PR intends to fix this issue.

Fixes: https://tracker.ceph.com/issues/59666

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@aaSharma14 aaSharma14 requested a review from a team as a code owner May 8, 2023 07:22
@aaSharma14 aaSharma14 requested review from avanthakkar and nizamial09 and removed request for a team May 8, 2023 07:22
because of an earlier fix delivered, there is a regression caused by it
due to which alerts are not getting displayed in the active alerts tab.
This PR intends to fix this issue.

Fixes: https://tracker.ceph.com/issues/59666

Signed-off-by: Aashish Sharma <aasharma@redhat.com>
@aaSharma14 aaSharma14 force-pushed the fix-cephPgImbalance-regression branch from 7a8f5a0 to d0a1431 Compare May 8, 2023 08:16
Copy link
Contributor

@avanthakkar avanthakkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aaSharma14
Copy link
Contributor Author

jenkins test make check

@aaSharma14
Copy link
Contributor Author

jenkins test dashboard

@nizamial09
Copy link
Member

make-check failure

@aaSharma14
Copy link
Contributor Author

jenkins test make check

@aaSharma14
Copy link
Contributor Author

jenkins retest this please

@aaSharma14
Copy link
Contributor Author

jenkins test make check

@aaSharma14
Copy link
Contributor Author

jenkins test api

@aaSharma14
Copy link
Contributor Author

jenkins test dashboard

@aaSharma14
Copy link
Contributor Author

jenkins test dashboard cephadm

@nizamial09 nizamial09 merged commit d5f1c06 into ceph:main May 16, 2023
9 of 14 checks passed
@nizamial09 nizamial09 deleted the fix-cephPgImbalance-regression branch May 16, 2023 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants