New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mgr/dashboard: fix regression caused by cephPgImabalance alert #51385
Merged
nizamial09
merged 1 commit into
ceph:main
from
rhcs-dashboard:fix-cephPgImbalance-regression
May 16, 2023
Merged
mgr/dashboard: fix regression caused by cephPgImabalance alert #51385
nizamial09
merged 1 commit into
ceph:main
from
rhcs-dashboard:fix-cephPgImbalance-regression
May 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because of an earlier fix delivered, there is a regression caused by it due to which alerts are not getting displayed in the active alerts tab. This PR intends to fix this issue. Fixes: https://tracker.ceph.com/issues/59666 Signed-off-by: Aashish Sharma <aasharma@redhat.com>
7a8f5a0
to
d0a1431
Compare
avanthakkar
approved these changes
May 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
jenkins test make check |
|
jenkins test dashboard |
nizamial09
approved these changes
May 8, 2023
|
make-check failure |
|
jenkins test make check |
|
jenkins retest this please |
|
jenkins test make check |
|
jenkins test api |
|
jenkins test dashboard |
|
jenkins test dashboard cephadm |
This was referenced May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of an earlier fix delivered for cephPgImbalance Alert(#51189), there is a regression caused by it due to which alerts are not getting displayed in the active alerts tab. This PR intends to fix this issue.
Fixes: https://tracker.ceph.com/issues/59666
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows