Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qa/tasks: Changing default mClock profile to high_recovery_ops #51449

Merged
merged 1 commit into from May 18, 2023
Merged

qa/tasks: Changing default mClock profile to high_recovery_ops #51449

merged 1 commit into from May 18, 2023

Conversation

amathuria
Copy link
Contributor

@amathuria amathuria commented May 11, 2023 •
edited

Change the mClock profile in tests to high_recovery_ops in order to finish scrubs in time

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@amathuria amathuria requested a review from a team as a code owner May 11, 2023 15:16
@github-actions github-actions bot added the rbd label May 11, 2023
@amathuria
Copy link
Contributor Author

@idryomov I have made this change to fix the issue RBD tests have been facing with very long scrub times in teuthology tests.

Waiting for - http://pulpito.front.sepia.ceph.com/amathuri-2023-05-11_04:31:10-rbd-main-distro-default-smithi/ to pass

@amathuria amathuria requested a review from idryomov May 11, 2023 15:20
idryomov
idryomov reviewed May 11, 2023
View reviewed changes
Copy link
Contributor

@idryomov idryomov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is something we want for all teuthology jobs, right? If so, I would rather set it in qa/tasks/cephadm.conf and qa/tasks/ceph.conf.template to avoid littering cluster definition snippets with this option.

@neha-ojha
Copy link
Member

This is something we want for all teuthology jobs, right? If so, I would rather set it in qa/tasks/cephadm.conf and qa/tasks/ceph.conf.template to avoid littering cluster definition snippets with this option.

+1

@amathuria amathuria force-pushed the wip-rbd-suite-change-mclock-profile branch from 37315e0 to 6bd41f5 Compare May 11, 2023 17:21
@github-actions github-actions bot added the tests label May 11, 2023
@amathuria
Copy link
Contributor Author

This is something we want for all teuthology jobs, right? If so, I would rather set it in qa/tasks/cephadm.conf and qa/tasks/ceph.conf.template to avoid littering cluster definition snippets with this option.

Thanks! Does this look okay?

@neha-ojha neha-ojha changed the title qa/clusters: Changing default mClock profile to high_recovery_ops qa/tasks: Changing default mClock profile to high_recovery_ops May 11, 2023
idryomov
idryomov reviewed May 12, 2023
View reviewed changes
Copy link
Contributor

@idryomov idryomov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please mention "Exiting scrub checking -- not all pgs scrubbed" error in the commit message so that it's clear what the symptom was.

qa/tasks/ceph.conf.template Outdated Show resolved Hide resolved
qa/tasks/cephadm.conf Outdated Show resolved Hide resolved
This was referenced May 16, 2023
Merged
Merged
@idryomov
Copy link
Contributor

idryomov commented May 16, 2023 •
edited

I'm confirming that this PR fixes the issue from the RBD suite side.

@ljflores
Copy link
Contributor

Rados suite summary available here: https://tracker.ceph.com/projects/rados/wiki/MAIN#httpstrellocomc1EFSeXDn1752-wip-yuri10-testing-2023-05-16-1243

@ljflores
Copy link
Contributor

jenkins test api

@ljflores
Copy link
Contributor

@yuriw might want to hold off on merging this since @idryomov is checking something from the RBD side.

@yuriw
Copy link
Contributor

yuriw commented May 17, 2023

@amathuria @idryomov
this was tested and can be merged if rados was sufficient, otherwise kick it back to the queue.

ref: https://trello.com/c/1EFSeXDn

@idryomov
Copy link
Contributor

@idryomov is checking something from the RBD side

It's OK from the RBD side but there are outstanding nits (non-blocking but it would be nice if they were addressed).

@idryomov
Copy link
Contributor

This fixes an issue introduced in #49975.

@idryomov
Copy link
Contributor

idryomov commented May 17, 2023 •
edited

there are outstanding nits (non-blocking but it would be nice if they were addressed)

Also a tracker ticket is needed for backporting to quincy and reef (that's where commits from #49975 are present as of today).

@amathuria
Copy link
Contributor Author

@idryomov is checking something from the RBD side

It's OK from the RBD side but there are outstanding nits (non-blocking but it would be nice if they were addressed).

@idryomov Sure I'll fix them

@amathuria
qa/tasks: Change default mClock profile to high_recovery_ops
a7c0029 
With the new mClock default profile, tests were failing with "Exiting scrub checking -- not all pgs scrubbed" due to slower scrubs.
Changing the default profile to high_recovery_ops for testing purposes will fix this issue.

Fixes: https://tracker.ceph.com/issues/61228
Signed-off-by: Aishwarya Mathuria <amathuri@redhat.com>
@amathuria amathuria force-pushed the wip-rbd-suite-change-mclock-profile branch from 6bd41f5 to a7c0029 Compare May 18, 2023 04:13
@amathuria
Copy link
Contributor Author

there are outstanding nits (non-blocking but it would be nice if they were addressed)

Also a tracker ticket is needed for backporting to quincy and reef (that's where commits from #49975 are present as of today).

@idryomov I have added the tracker ticket to the commit message as well

@idryomov idryomov merged commit 9555107 into ceph:main May 18, 2023
12 of 13 checks passed
This was referenced May 18, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idryomov idryomov idryomov approved these changes

@neha-ojha neha-ojha neha-ojha approved these changes

Assignees
No one assigned
Labels
core needs-qa rbd ready-to-merge TESTED tests
Projects
None yet
Milestone
No milestone
5 participants
@amathuria @neha-ojha @idryomov @ljflores @yuriw