New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

librbd: internal.cc: 1967: FAILED assert(watchers.size() == 1) #5171

Merged
merged 1 commit into from Jul 24, 2015

Conversation

Projects
None yet
4 participants
@smithfarm
Contributor

smithfarm commented Jul 8, 2015

librbd: assertion failure race condition if watch disconnected
It's possible for librbd's watch of the header object to be reset by
connection issues just prior to the image being removed.  This will
causes an assertion failure which assumes at least one watcher on the
image.

Fixes: #12176
Backport: hammer, firefly
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit af276de)

@smithfarm smithfarm added this to the firefly milestone Jul 8, 2015

@smithfarm smithfarm self-assigned this Jul 8, 2015

@ghost ghost changed the title from librbd/internal.cc: 1967: FAILED assert(watchers.size() == 1) to librbd: internal.cc: 1967: FAILED assert(watchers.size() == 1) Jul 21, 2015

@smithfarm

This comment has been minimized.

Contributor

smithfarm commented Jul 24, 2015

@jdurgin: This commit has passed integration tests (http://tracker.ceph.com/issues/11644#teuthology-run-commitb2aaddd3a06ac13c46df659e1f2b3119f5675802-firefly-backports-july-2015) -- is it OK to merge? I'm asking you because you merged the master commit that this is a backport of: #5090

jdurgin added a commit that referenced this pull request Jul 24, 2015

Merge pull request #5171 from SUSE/wip-12240-firefly
librbd: internal.cc: 1967: FAILED assert(watchers.size() == 1)

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

@jdurgin jdurgin merged commit 94060b7 into ceph:firefly Jul 24, 2015

@smithfarm smithfarm deleted the SUSE:wip-12240-firefly branch Jul 24, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment