Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: TEST_crush_reject_empty must not run a mon #5195

Closed
wants to merge 3 commits into from

Conversation

@ghost ghost added the tests label Jul 10, 2015
@ghost ghost assigned tchaikov Jul 10, 2015
@ghost

This comment has been minimized.

Copy link
Author

ghost commented Jul 10, 2015

@tchaikov it's test only, no harm done ;-)

After a make check fails, it shows a summary but not the output of the
failed tests although they contain information to diagnose the problem.

Set the VERBOSE=true automake variable which is documented to collect
and display the failed script output at the end of a run (the content of
the test-suite.log file (valid from automake-1.11 up).

http://www.gnu.org/software/automake/manual/automake.html#index-VERBOSE

Also remove the run-make-check.sh that did the same in a way that is not
compatible with automake-1.11.

Signed-off-by: Loic Dachary <ldachary@redhat.com>
(cherry picked from commit 3a55cb0)
@ghost

This comment has been minimized.

Copy link
Author

ghost commented Jul 10, 2015

the bot no longer displays the errors because it assumes make check will, backport 45d95b9 for that to happen

@tchaikov

This comment has been minimized.

Copy link
Contributor

tchaikov commented Jul 10, 2015

@dachary need to source ceph-helpers.sh for run_osd(). will prepare a pull request on top of yours tomorrow.

at least one OSD is needed, because monitor will check the crush map against max_osd. a zero max_id will disable this feature.

@ghost

This comment has been minimized.

Copy link
Author

ghost commented Jul 10, 2015

@tchaikov I'm trying to figure out why the bot does not show any output even with the VERBOSE thing. Will also include ceph-helpers.sh.

@ghost

This comment has been minimized.

Copy link
Author

ghost commented Jul 10, 2015

@tchaikov nevermind... the VERBOSE patch works, I must have done a combo of bad things to think it did not...

ldachary added 2 commits Apr 21, 2015
To display the output in case the command did not fail with the expected
output.

Signed-off-by: Loic Dachary <ldachary@redhat.com>
(cherry picked from commit 5871781)
Back in Hammer, the osd-crush.sh individual tests did not run the
monitor, it was taken care of by the run() function. An attempt to run
another mon fails with:

error: IO lock testdir/osd-crush/a/store.db/LOCK: Resource temporarily
unavailable

This problem was introduced by cc1cc03
from #4936

http://tracker.ceph.com/issues/11975 Refs: #11975

Signed-off-by: Loic Dachary <ldachary@redhat.com>
@ghost

This comment has been minimized.

Copy link
Author

ghost commented Jul 11, 2015

Error EPERM: Failed to parse crushmap: error running crushmap through crushtool: (1) Operation not permitted

this looks like an actual problem. @tchaikov what do you think ?

@tchaikov

This comment has been minimized.

Copy link
Contributor

tchaikov commented Jul 11, 2015

@dachary, turns out we need more changes to appease the tests, i pulled together a new pr on top of yours: #5208.

@ghost

This comment has been minimized.

Copy link
Author

ghost commented Jul 11, 2015

#5208 is better

@ghost ghost closed this Jul 11, 2015
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.