Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build/ops: ceph.spec.in: 50-rbd.rules conditional is wrong #5207

Merged
1 commit merged into from Aug 30, 2015

Conversation

Projects
None yet
3 participants
@smithfarm
Copy link
Contributor

smithfarm commented Jul 11, 2015

@ghost

This comment has been minimized.

Copy link

ghost commented Jul 11, 2015

@smithfarm please ignore the bot false negative, it will be fixed by #5208

@ghost

This comment has been minimized.

Copy link

ghost commented Jul 11, 2015

@smithfarm the fix was merged, could you please rebase & repush to trigger the bot once more ?

ceph.spec.in: use _udevrulesdir to eliminate conditionals
The conditionals governing where 50-rbd.rules is installed were not doing the
right thing on SUSE distros.

Start using the %_udevrulesdir RPM macro, while taking care that it is defined
and set to the right value. Use it to eliminate some conditionals around other
udev rules files as well.

http://tracker.ceph.com/issues/12166 Fixes: #12166

Signed-off-by: Nathan Cutler <ncutler@suse.com>
(cherry picked from commit 8aa758e)

Conflicts:
	ceph.spec.in
            hammer does not yet have _with_systemd or ceph_daemon.py

@smithfarm smithfarm force-pushed the SUSE:wip-12267-hammer branch from 464f594 to 4eb58ad Jul 12, 2015

@ghost

This comment has been minimized.

Copy link

ghost commented Aug 30, 2015

Pass http://tracker.ceph.com/issues/12701#ceph-deploy http://tracker.ceph.com/issues/12701#upgrade (there are job failures but they are unrelated to packaging)

ghost pushed a commit that referenced this pull request Aug 30, 2015

Loic Dachary
Merge pull request #5207 from SUSE/wip-12267-hammer
ceph.spec.in: 50-rbd.rules conditional is wrong

Reviewed-by: Loic Dachary <ldachary@redhat.com>

@ghost ghost merged commit f7e76d2 into ceph:hammer Aug 30, 2015

@smithfarm smithfarm deleted the SUSE:wip-12267-hammer branch Sep 5, 2015

@ghost ghost changed the title ceph.spec.in: 50-rbd.rules conditional is wrong build/ops: ceph.spec.in: 50-rbd.rules conditional is wrong Sep 13, 2015

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.