Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build/ops: ceph.spec.in: ceph-common needs python-argparse on older distros, but doesn't require it #5216

Merged
1 commit merged into from Aug 30, 2015

Conversation

Projects
None yet
3 participants
@smithfarm
Copy link
Contributor

smithfarm commented Jul 13, 2015

@smithfarm smithfarm self-assigned this Jul 13, 2015

@smithfarm smithfarm added this to the hammer milestone Jul 13, 2015

@smithfarm smithfarm assigned theanalyst and unassigned smithfarm Jul 13, 2015

@ghost ghost changed the title ceph-common needs python-argparse on older distros, but doesn't require it ceph.spec.in: ceph-common needs python-argparse on older distros, but doesn't require it Jul 15, 2015

@ghost

This comment has been minimized.

Copy link

ghost commented Jul 15, 2015

@smithfarm could you please rebase and remove the DNM when you did ?

@ghost ghost changed the title ceph.spec.in: ceph-common needs python-argparse on older distros, but doesn't require it DNM: ceph.spec.in: ceph-common needs python-argparse on older distros, but doesn't require it Jul 15, 2015

@smithfarm smithfarm force-pushed the SUSE:wip-12269-hammer branch from 09acb6f to 7620a9e Jul 16, 2015

ceph.spec.in: python-argparse only in Python 2.6
argparse is a widely-used Python module for parsing command-line arguments.
Ceph makes heavy use of Python scripts, both in the build environment and on
cluster nodes and clients.

Until Python 2.6, argparse was distributed separately from Python proper.
As of 2.7 it is part of the Python standard library.

Although the python package in a given distro may or may not Provide:
python-argparse, this cannot be relied upon.

Therefore, this commit puts appropriate conditionals around Requires:
python-argparse and BuildRequires: python-argparse. It does so for Red
Hat/CentOS and SUSE only, because the last Fedora version with Python 2.6
was Fedora 13, which is EOL.

argparse is required by both the ceph and ceph-common packages, but since ceph
requires ceph-common, the argparse Requires and BuildRequires need only appear
once, under ceph-common.

http://tracker.ceph.com/issues/12034 Fixes: #12034

Signed-off-by: Nathan Cutler <ncutler@suse.com>
(cherry picked from commit 23171c9)

@smithfarm smithfarm force-pushed the SUSE:wip-12269-hammer branch from 7620a9e to 8b576bd Jul 16, 2015

@smithfarm smithfarm changed the title DNM: ceph.spec.in: ceph-common needs python-argparse on older distros, but doesn't require it ceph.spec.in: ceph-common needs python-argparse on older distros, but doesn't require it Jul 16, 2015

@smithfarm

This comment has been minimized.

Copy link
Contributor Author

smithfarm commented Jul 16, 2015

@dachary OK, done.

@theanalyst theanalyst added build/ops and removed core labels Jul 28, 2015

@ghost

This comment has been minimized.

Copy link

ghost commented Aug 30, 2015

Pass http://tracker.ceph.com/issues/12701#ceph-deploy http://tracker.ceph.com/issues/12701#upgrade (there are job failures but they are unrelated to packaging)

ghost pushed a commit that referenced this pull request Aug 30, 2015

Loic Dachary
Merge pull request #5216 from SUSE/wip-12269-hammer
ceph.spec.in: ceph-common needs python-argparse on older distros, but doesn't require it

Reviewed-by: Loic Dachary <ldachary@redhat.com>

@ghost ghost merged commit d1feb04 into ceph:hammer Aug 30, 2015

@smithfarm smithfarm deleted the SUSE:wip-12269-hammer branch Sep 5, 2015

@ghost ghost changed the title ceph.spec.in: ceph-common needs python-argparse on older distros, but doesn't require it build/ops: ceph.spec.in: ceph-common needs python-argparse on older distros, but doesn't require it Sep 13, 2015

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.