New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build/ops: ceph-common needs python-argparse on older distros, but doesn't require it #5217

Merged
merged 1 commit into from Sep 6, 2015

Conversation

Projects
None yet
2 participants
@smithfarm
Contributor

smithfarm commented Jul 13, 2015

ceph.spec.in: python-argparse only in Python 2.6
argparse is a widely-used Python module for parsing command-line arguments.
Ceph makes heavy use of Python scripts, both in the build environment and on
cluster nodes and clients.

Until Python 2.6, argparse was distributed separately from Python proper.
As of 2.7 it is part of the Python standard library.

Although the python package in a given distro may or may not Provide:
python-argparse, this cannot be relied upon.

Therefore, this commit puts appropriate conditionals around Requires:
python-argparse and BuildRequires: python-argparse. It does so for Red
Hat/CentOS and SUSE only, because the last Fedora version with Python 2.6
was Fedora 13, which is EOL.

argparse is required by both the ceph and ceph-common packages, but since ceph
requires ceph-common, the argparse Requires and BuildRequires need only appear
once, under ceph-common.

http://tracker.ceph.com/issues/12034 Fixes: #12034

Signed-off-by: Nathan Cutler <ncutler@suse.com>
(cherry picked from commit 23171c9)

Conflicts:
	ceph.spec.in

@smithfarm smithfarm added this to the firefly milestone Jul 13, 2015

@smithfarm smithfarm self-assigned this Jul 13, 2015

@ghost

This comment has been minimized.

ghost commented Sep 6, 2015

Reviewed-by: Loic Dachary <ldachary@redhat.com>
@smithfarm

This comment has been minimized.

Contributor

smithfarm commented Sep 6, 2015

This patch has passed two upgrade suites (ubuntu_14.04 and centos_6). See http://tracker.ceph.com/issues/11644#upgrade for details.

smithfarm added a commit that referenced this pull request Sep 6, 2015

Merge pull request #5217 from SUSE/wip-12268-firefly
ceph-common needs python-argparse on older distros, but doesn't require it

Reviewed-by: Loic Dachary <ldachary@redhat.com>

@smithfarm smithfarm merged commit 4a3c178 into ceph:firefly Sep 6, 2015

@smithfarm smithfarm deleted the SUSE:wip-12268-firefly branch Sep 6, 2015

@ghost ghost changed the title from ceph-common needs python-argparse on older distros, but doesn't require it to build/ops: ceph-common needs python-argparse on older distros, but doesn't require it Oct 24, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment