Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ceph.spec.in: fix libs-compat / devel-compat conditional #5219

Merged
merged 1 commit into from Oct 18, 2015

Conversation

Projects
None yet
4 participants
@ktdreyer
Copy link
Member

ktdreyer commented Jul 13, 2015

In the RPM .spec's %files list, the "with libs-compat" conditional was inadvertantly exended to cover the files list for ceph-devel-compat as well.

The "with libs-compat" conditional should only cover the "ceph-libs-compat" package, and not affect "ceph-devel-compat".

Fixes http://tracker.ceph.com/issues/12315

ceph.spec.in: fix libs-compat / devel-compat conditional
In the RPM .spec's %files list, the "with libs-compat" conditional was
inadvertantly exended to cover the files list for ceph-devel-compat as
well.

The "with libs-compat" conditional should only cover the
"ceph-libs-compat" package, and not affect "ceph-devel-compat".

http://tracker.ceph.com/issues/12315 Fixes: #12315

Signed-off-by: Ken Dreyer <kdreyer@redhat.com>
@ktdreyer

This comment has been minimized.

Copy link
Member Author

ktdreyer commented Jul 13, 2015

By the way, looking at the introduction of ceph-libs-compat (6c264f2), we should plan to drop that package at some point. It is only relevant for users who are on a Ceph version prior to the time when librados/librbd/libcephfs were split (ec776f4), and that was a long time ago (pre-argonaut).

@smithfarm

This comment has been minimized.

Copy link
Contributor

smithfarm commented Jul 13, 2015

Huh! I was just looking at that today and wondering why it covered both.

@smithfarm

This comment has been minimized.

Copy link
Contributor

smithfarm commented Jul 13, 2015

As for dropping ceph-libs-compat, I'm all for it. Does there need to be an announcement and a waiting period?

@smithfarm

This comment has been minimized.

Copy link
Contributor

smithfarm commented Jul 13, 2015

LGTM

Reviewed-by: Nathan Cutler <ncutler@suse.com>
@ktdreyer

This comment has been minimized.

Copy link
Member Author

ktdreyer commented Jul 13, 2015

Thanks! I've pushed a "wip-spec-tidying" branch that has some comment fixes, as well as the ceph-libs removal.

@smithfarm smithfarm added the cleanup label Jul 14, 2015

liewegas added a commit that referenced this pull request Oct 18, 2015

Merge pull request #5219 from ceph/wip-12315-libs-compat-conditional
ceph.spec.in: fix libs-compat / devel-compat conditional

Reviewed-by: Nathan Cutler <ncutler@suse.com>

@liewegas liewegas merged commit 08b381e into master Oct 18, 2015

@liewegas liewegas deleted the wip-12315-libs-compat-conditional branch Oct 18, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.