Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build/ops: ceph.spec.in: running fdupes unnecessarily #5223

Merged
merged 1 commit into from Sep 4, 2015

Conversation

Projects
None yet
4 participants
@smithfarm
Copy link
Contributor

smithfarm commented Jul 14, 2015

ceph.spec.in: do not run fdupes, even on SLE/openSUSE
In openSUSE there is a policy to use %fdupes in the spec file if RPMLINT
complains about duplicate files wasting space in the filesystem.

However, RPMLINT is not so complaining, so drop fdupes.

http://tracker.ceph.com/issues/12301 Fixes: #12301

Signed-off-by: Nathan Cutler <ncutler@suse.com>
(cherry picked from commit 53072b9)

@smithfarm smithfarm self-assigned this Jul 14, 2015

@smithfarm smithfarm added this to the hammer milestone Jul 14, 2015

@smithfarm smithfarm assigned theanalyst and unassigned smithfarm Jul 14, 2015

@smithfarm smithfarm added build/ops and removed core labels Jul 14, 2015

@ghost

This comment has been minimized.

Copy link

ghost commented Jul 14, 2015

second occurrence of this false negative in two days. If that frequency is confirmed I'll backport the necessary changes.

@ghost ghost changed the title ceph.spec.in running fdupes unnecessarily ceph.spec.in: running fdupes unnecessarily Jul 16, 2015

@smithfarm

This comment has been minimized.

Copy link
Contributor Author

smithfarm commented Sep 4, 2015

@ktdreyer And in hammer, too?

@ktdreyer ktdreyer merged commit cdde626 into ceph:hammer Sep 4, 2015

ktdreyer added a commit that referenced this pull request Sep 4, 2015

Merge pull request #5223 from SUSE/wip-12305-hammer
ceph.spec.in: running fdupes unnecessarily

Reviewed-by: Ken Dreyer <kdreyer@redhat.com>
@ktdreyer

This comment has been minimized.

Copy link
Member

ktdreyer commented Sep 4, 2015

Thanks!

@smithfarm smithfarm deleted the SUSE:wip-12305-hammer branch Sep 5, 2015

@ghost ghost changed the title ceph.spec.in: running fdupes unnecessarily build/ops: ceph.spec.in: running fdupes unnecessarily Sep 13, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.