Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build/ops: 50-rbd.rules conditional is wrong #5225

merged 1 commit into from Sep 6, 2015


Copy link

smithfarm commented Jul 14, 2015

The conditionals governing where 50-rbd.rules is installed were not doing the
right thing on SUSE distros.

Start using the %_udevrulesdir RPM macro, while taking care that it is defined
and set to the right value. Use it to eliminate some conditionals around other
udev rules files as well. Fixes: #12166

Signed-off-by: Nathan Cutler <>
(cherry picked from commit 8aa758e)

            master spec file has diverged significantly from firefly
@smithfarm smithfarm self-assigned this Jul 14, 2015
@smithfarm smithfarm added bug fix core build/ops and removed core labels Jul 14, 2015

This comment has been minimized.

Copy link

ghost commented Sep 6, 2015

Reviewed-by: Loic Dachary <>

This comment has been minimized.

Copy link
Contributor Author

smithfarm commented Sep 6, 2015

This patch has passed two upgrade suites (ubuntu_14.04 and centos_6). See for details.

smithfarm added a commit that referenced this pull request Sep 6, 2015 50-rbd.rules conditional is wrong

Reviewed-by: Loic Dachary <>
@smithfarm smithfarm merged commit beff99b into ceph:firefly Sep 6, 2015
@smithfarm smithfarm deleted the SUSE:wip-12266-firefly branch Sep 6, 2015
@ghost ghost changed the title 50-rbd.rules conditional is wrong build/ops: 50-rbd.rules conditional is wrong Oct 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants
You can’t perform that action at this time.