Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build/ops: ceph.spec.in: 50-rbd.rules conditional is wrong #5225

Merged
merged 1 commit into from Sep 6, 2015

Conversation

Projects
None yet
2 participants
@smithfarm
Copy link
Contributor

commented Jul 14, 2015

ceph.spec.in: use _udevrulesdir to eliminate conditionals
The conditionals governing where 50-rbd.rules is installed were not doing the
right thing on SUSE distros.

Start using the %_udevrulesdir RPM macro, while taking care that it is defined
and set to the right value. Use it to eliminate some conditionals around other
udev rules files as well.

http://tracker.ceph.com/issues/12166 Fixes: #12166

Signed-off-by: Nathan Cutler <ncutler@suse.com>
(cherry picked from commit 8aa758e)

Conflicts:
	ceph.spec.in
            master spec file has diverged significantly from firefly

@smithfarm smithfarm self-assigned this Jul 14, 2015

@smithfarm smithfarm added this to the firefly milestone Jul 14, 2015

@smithfarm smithfarm added bug fix core build/ops and removed core labels Jul 14, 2015

@ghost

This comment has been minimized.

Copy link

commented Sep 6, 2015

Reviewed-by: Loic Dachary <ldachary@redhat.com>
@smithfarm

This comment has been minimized.

Copy link
Contributor Author

commented Sep 6, 2015

This patch has passed two upgrade suites (ubuntu_14.04 and centos_6). See http://tracker.ceph.com/issues/11644#upgrade for details.

smithfarm added a commit that referenced this pull request Sep 6, 2015

Merge pull request #5225 from SUSE/wip-12266-firefly
ceph.spec.in: 50-rbd.rules conditional is wrong

Reviewed-by: Loic Dachary <ldachary@redhat.com>

@smithfarm smithfarm merged commit beff99b into ceph:firefly Sep 6, 2015

@smithfarm smithfarm deleted the SUSE:wip-12266-firefly branch Sep 6, 2015

@ghost ghost changed the title ceph.spec.in: 50-rbd.rules conditional is wrong build/ops: ceph.spec.in: 50-rbd.rules conditional is wrong Oct 24, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.