New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: Civetweb RGW appears to report full size of object as downloaded when only partially downloaded #5231

Merged
merged 1 commit into from Jul 28, 2015

Conversation

Projects
None yet
4 participants
@theanalyst
Member

theanalyst commented Jul 14, 2015

rgw: error out if frontend did not send all data
Fixes: #11851
The civetweb mg_write() doesn't return error when it can't flush all data
to the user, it just sends the total number of bytes written. Modified the
client io to return total number of bytes and return an error if didn't
send anything.

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>
(cherry picked from commit daa679c)

@theanalyst theanalyst self-assigned this Jul 14, 2015

@theanalyst theanalyst added this to the hammer milestone Jul 14, 2015

ghost pushed a commit that referenced this pull request Jul 15, 2015

Merge pull request #5231: Civetweb RGW appears to report full size of…
… object as downloaded when only partially downloaded

Reviewed-by: Loic Dachary <ldachary@redhat.com>

ghost pushed a commit that referenced this pull request Jul 15, 2015

Merge pull request #5231: Civetweb RGW appears to report full size of…
… object as downloaded when only partially downloaded

Reviewed-by: Loic Dachary <ldachary@redhat.com>

ghost pushed a commit that referenced this pull request Jul 16, 2015

Merge pull request #5231: Civetweb RGW appears to report full size of…
… object as downloaded when only partially downloaded

Reviewed-by: Loic Dachary <ldachary@redhat.com>

ghost pushed a commit that referenced this pull request Jul 19, 2015

Merge pull request #5231: Civetweb RGW appears to report full size of…
… object as downloaded when only partially downloaded

Reviewed-by: Loic Dachary <ldachary@redhat.com>

ghost pushed a commit that referenced this pull request Jul 19, 2015

Merge pull request #5231: Civetweb RGW appears to report full size of…
… object as downloaded when only partially downloaded

Reviewed-by: Loic Dachary <ldachary@redhat.com>

ghost pushed a commit that referenced this pull request Jul 19, 2015

Merge pull request #5231: Civetweb RGW appears to report full size of…
… object as downloaded when only partially downloaded

Reviewed-by: Loic Dachary <ldachary@redhat.com>

ghost pushed a commit that referenced this pull request Jul 19, 2015

Merge pull request #5231: Civetweb RGW appears to report full size of…
… object as downloaded when only partially downloaded

Reviewed-by: Loic Dachary <ldachary@redhat.com>

ghost pushed a commit that referenced this pull request Jul 19, 2015

Merge pull request #5231: Civetweb RGW appears to report full size of…
… object as downloaded when only partially downloaded

Reviewed-by: Loic Dachary <ldachary@redhat.com>

@theanalyst theanalyst added rgw and removed core labels Jul 28, 2015

@ghost

This comment has been minimized.

ghost commented Jul 28, 2015

@oritwas does this hammer backport looks good to merge ? It went through a rgw suite ( http://tracker.ceph.com/issues/11990#rgw ), only one job failed because of a radosgw-agent failure specific to Ubuntu 12.04 (but succeded on 14.04).

oritwas added a commit that referenced this pull request Jul 28, 2015

Merge pull request #5231 from theanalyst/wip-12243-hammer
Civetweb RGW appears to report full size of object as downloaded when only partially downloaded

@oritwas oritwas merged commit 8355bda into ceph:hammer Jul 28, 2015

@ghost ghost changed the title from Civetweb RGW appears to report full size of object as downloaded when only partially downloaded to rgw: Civetweb RGW appears to report full size of object as downloaded when only partially downloaded Aug 4, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment