New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

librbd: internal.cc: 1967: FAILED assert(watchers.size() == 1) #5243

Merged
1 commit merged into from Jul 28, 2015

Conversation

Projects
None yet
4 participants
@theanalyst
Member

theanalyst commented Jul 14, 2015

librbd: assertion failure race condition if watch disconnected
It's possible for librbd's watch of the header object to be reset by
connection issues just prior to the image being removed.  This will
causes an assertion failure which assumes at least one watcher on the
image.

Fixes: #12176
Backport: hammer, firefly
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit af276de)

@theanalyst theanalyst self-assigned this Jul 14, 2015

@theanalyst theanalyst added this to the hammer milestone Jul 14, 2015

ghost pushed a commit that referenced this pull request Jul 15, 2015

Merge pull request #5243: librbd/internal.cc: 1967: FAILED assert(wat…
…chers.size() == 1)

Reviewed-by: Loic Dachary <ldachary@redhat.com>

ghost pushed a commit that referenced this pull request Jul 15, 2015

Merge pull request #5243: librbd/internal.cc: 1967: FAILED assert(wat…
…chers.size() == 1)

Reviewed-by: Loic Dachary <ldachary@redhat.com>

ghost pushed a commit that referenced this pull request Jul 16, 2015

Merge pull request #5243: librbd/internal.cc: 1967: FAILED assert(wat…
…chers.size() == 1)

Reviewed-by: Loic Dachary <ldachary@redhat.com>

ghost pushed a commit that referenced this pull request Jul 19, 2015

Merge pull request #5243: librbd/internal.cc: 1967: FAILED assert(wat…
…chers.size() == 1)

Reviewed-by: Loic Dachary <ldachary@redhat.com>

ghost pushed a commit that referenced this pull request Jul 19, 2015

Merge pull request #5243: librbd/internal.cc: 1967: FAILED assert(wat…
…chers.size() == 1)

Reviewed-by: Loic Dachary <ldachary@redhat.com>

ghost pushed a commit that referenced this pull request Jul 19, 2015

Merge pull request #5243: librbd/internal.cc: 1967: FAILED assert(wat…
…chers.size() == 1)

Reviewed-by: Loic Dachary <ldachary@redhat.com>

ghost pushed a commit that referenced this pull request Jul 19, 2015

Merge pull request #5243: librbd/internal.cc: 1967: FAILED assert(wat…
…chers.size() == 1)

Reviewed-by: Loic Dachary <ldachary@redhat.com>

ghost pushed a commit that referenced this pull request Jul 19, 2015

Merge pull request #5243: librbd/internal.cc: 1967: FAILED assert(wat…
…chers.size() == 1)

Reviewed-by: Loic Dachary <ldachary@redhat.com>

@theanalyst theanalyst added rbd and removed core labels Jul 28, 2015

@ghost

This comment has been minimized.

ghost commented Jul 28, 2015

@jdurgin does this hammer backport looks good to merge ? It went through a rbd suite ( http://tracker.ceph.com/issues/11990#rbd ).

@jdurgin

This comment has been minimized.

Member

jdurgin commented Jul 28, 2015

👍

ghost pushed a commit that referenced this pull request Jul 28, 2015

Loic Dachary
Merge pull request #5243 from theanalyst/wip-12239-hammer
librbd/internal.cc: 1967: FAILED assert(watchers.size() == 1)

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

@ghost ghost merged commit 52d0e5d into ceph:hammer Jul 28, 2015

@ghost ghost changed the title from librbd/internal.cc: 1967: FAILED assert(watchers.size() == 1) to librbd: internal.cc: 1967: FAILED assert(watchers.size() == 1) Aug 4, 2015

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment