New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mon: add an "osd crush tree" command #5248

Merged
1 commit merged into from Jul 29, 2015

Conversation

Projects
None yet
5 participants
@tchaikov
Contributor

tchaikov commented Jul 15, 2015

@tchaikov tchaikov added this to the hammer milestone Jul 15, 2015

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Jul 15, 2015

@theanalyst could you help me test it in the next qa run? thanks =)

@jecluis

This comment has been minimized.

Member

jecluis commented Jul 15, 2015

is this a backport of a feature?

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Jul 15, 2015

it's a backport. removing the "feature" tag if "feature" and "backport" are mutual exclusive.

@tchaikov tchaikov removed the feature label Jul 15, 2015

@jecluis

This comment has been minimized.

Member

jecluis commented Jul 15, 2015

Traditionally, we've backported only bug fixes. This is clearly a feature, regardless of being tagged as such or not. I'm just wondering how lenient is the policy regarding backporting features nowadays :)

@theanalyst

This comment has been minimized.

Member

theanalyst commented Jul 15, 2015

@tchaikov sure all open prs with milestone hammer will make it into the next round of integration testing..

@jecluis jecluis added the feature label Jul 15, 2015

@smithfarm

This comment has been minimized.

Contributor

smithfarm commented Jul 15, 2015

one would think that at least these two -- "bug fix" and "feature" -- would be mutually exclusive

@smithfarm smithfarm added core and removed bug fix labels Jul 15, 2015

mon: add an "osd crush tree" command
* to print crush buckets/items in a tree

Fixes: #11833
Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit 5436c29)

Conflicts:
	src/test/mon/osd-crush.sh:
		do not start mon as run() takes care of it already

ghost pushed a commit that referenced this pull request Jul 15, 2015

Merge pull request #5248: mon: add an "osd crush tree" command
Reviewed-by: Loic Dachary <ldachary@redhat.com>

ghost pushed a commit that referenced this pull request Jul 15, 2015

Merge pull request #5248: mon: add an "osd crush tree" command
Reviewed-by: Loic Dachary <ldachary@redhat.com>

ghost pushed a commit that referenced this pull request Jul 16, 2015

Merge pull request #5248: mon: add an "osd crush tree" command
Reviewed-by: Loic Dachary <ldachary@redhat.com>

ghost pushed a commit that referenced this pull request Jul 19, 2015

Merge pull request #5248: mon: add an "osd crush tree" command
Reviewed-by: Loic Dachary <ldachary@redhat.com>

ghost pushed a commit that referenced this pull request Jul 19, 2015

Merge pull request #5248: mon: add an "osd crush tree" command
Reviewed-by: Loic Dachary <ldachary@redhat.com>

ghost pushed a commit that referenced this pull request Jul 19, 2015

Merge pull request #5248: mon: add an "osd crush tree" command
Reviewed-by: Loic Dachary <ldachary@redhat.com>

ghost pushed a commit that referenced this pull request Jul 19, 2015

Merge pull request #5248: mon: add an "osd crush tree" command
Reviewed-by: Loic Dachary <ldachary@redhat.com>

ghost pushed a commit that referenced this pull request Jul 19, 2015

Merge pull request #5248: mon: add an "osd crush tree" command
Reviewed-by: Loic Dachary <ldachary@redhat.com>
@ghost

This comment has been minimized.

ghost commented Jul 28, 2015

@tchaikov does this hammer backport looks good to merge ? It went through a rados suite ( http://tracker.ceph.com/issues/11990#rados ). There was a transient error ( http://tracker.ceph.com/issues/12469 ) but I don't think it's related.

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Jul 29, 2015

@dachary @theanalyst LGTM.

ghost pushed a commit that referenced this pull request Jul 29, 2015

Loic Dachary
Merge pull request #5248 from ceph/wip-11833-hammer
mon: add an "osd crush tree" command

Reviewed-by: Kefu Chai <kchai@redhat.com>

@ghost ghost merged commit e3d17e4 into hammer Jul 29, 2015

@tchaikov tchaikov deleted the wip-11833-hammer branch Aug 11, 2015

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment