Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mon: implicit erasure code crush ruleset is not validated #5276

Merged
3 commits merged into from Sep 6, 2015

Conversation

Projects
None yet
2 participants
@ghost
Copy link

ghost commented Jul 17, 2015

@ghost ghost self-assigned this Jul 17, 2015

@ghost ghost added this to the hammer milestone Jul 17, 2015

@ghost ghost added bug fix core labels Jul 17, 2015

ghost pushed a commit that referenced this pull request Jul 19, 2015

Merge pull request #5276: implicit erasure code crush ruleset is not …
…validated

Reviewed-by: Loic Dachary <ldachary@redhat.com>

ghost pushed a commit that referenced this pull request Jul 19, 2015

Merge pull request #5276: implicit erasure code crush ruleset is not …
…validated

Reviewed-by: Loic Dachary <ldachary@redhat.com>

ghost pushed a commit that referenced this pull request Jul 19, 2015

Merge pull request #5276: implicit erasure code crush ruleset is not …
…validated

Reviewed-by: Loic Dachary <ldachary@redhat.com>

ghost pushed a commit that referenced this pull request Jul 19, 2015

Merge pull request #5276: implicit erasure code crush ruleset is not …
…validated

Reviewed-by: Loic Dachary <ldachary@redhat.com>
@ghost

This comment has been minimized.

Copy link
Author

ghost commented Jul 19, 2015

FAIL: test/ceph_objectstore_tool.py
===================================
vstarting.... DONE
Wait for health_ok... DONE
Traceback (most recent call last):
  File "./test/ceph_objectstore_tool.py", line 920, in 
    status = main(sys.argv[1:])
  File "./test/ceph_objectstore_tool.py", line 255, in main
    REPID = get_pool_id(REP_POOL, nullfd)
  File "./test/ceph_objectstore_tool.py", line 45, in get_pool_id
    return check_output(cmd, stderr=nullfd).split()[3]
  File "/usr/lib64/python2.7/subprocess.py", line 575, in check_output
    raise CalledProcessError(retcode, cmd, output=output)
subprocess.CalledProcessError: Command '['./ceph', 'osd', 'pool', 'stats', 'rep_pool']' returned non-zero exit status 2

strange, repeating.

@ghost ghost changed the title implicit erasure code crush ruleset is not validated DNM: implicit erasure code crush ruleset is not validated Jul 19, 2015

Mykola Golub and others added some commits Feb 26, 2015

vstart.sh: set PATH to include pwd
ceph-mon needs crushtool to be in PATH. Don't set if it is run
from ceph_vstart_wrapper, which already sets it as it needs.

Signed-off-by: Mykola Golub <mgolub@mirantis.com>
(cherry picked from commit e08bccf)
erasure-code: set max_size to chunk_count() instead of 20 for shec
See 8b64fe9 for a detailed explanation.

Signed-off-by: Loic Dachary <ldachary@redhat.com>
(cherry picked from commit a44499f)
mon: test the crush ruleset when creating a pool
We want to fix the following scenario:

 * an erasure code plugin (or another part of the code) creates a
   ruleset
 * the ruleset crashes during mapping (for whatever reason)
 * ceph osd pool create uses the bugous ruleset
 * the monitors try to do mapping a crash

Having a bugous ruleset in the crush map is very difficult prevent. The
catastrophic event of using it with a newly created pool can however be
prevented by calling the CrushTester just before creating the pool and
after all implicit or explicit crush ruleset creation happened.

http://tracker.ceph.com/issues/11814 Fixes: #11814

Signed-off-by: Loic Dachary <ldachary@redhat.com>
(cherry picked from commit f1e86be)

Conflicts:
	src/test/mon/osd-crush.sh
          removed the run_mon because in hammer it is shared
          between all tests
        src/mon/OSDMonitor.cc
          prepare_new_pool changed stringstream to *ostream

@ghost ghost changed the title DNM: implicit erasure code crush ruleset is not validated implicit erasure code crush ruleset is not validated Aug 31, 2015

ghost pushed a commit that referenced this pull request Aug 31, 2015

Merge pull request #5276: implicit erasure code crush ruleset is not …
…validated

Reviewed-by: Loic Dachary <ldachary@redhat.com>

ghost pushed a commit that referenced this pull request Sep 1, 2015

Merge pull request #5276: implicit erasure code crush ruleset is not …
…validated

Reviewed-by: Loic Dachary <ldachary@redhat.com>

ghost pushed a commit that referenced this pull request Sep 2, 2015

Merge pull request #5276: implicit erasure code crush ruleset is not …
…validated

Reviewed-by: Loic Dachary <ldachary@redhat.com>
@ghost

This comment has been minimized.

Copy link
Author

ghost commented Sep 6, 2015

ghost pushed a commit that referenced this pull request Sep 6, 2015

Loic Dachary
Merge pull request #5276 from dachary/wip-11824-hammer
implicit erasure code crush ruleset is not validated

Reviewed-by: Loic Dachary <ldachary@redhat.com>

@ghost ghost merged commit 4125196 into ceph:hammer Sep 6, 2015

@ghost ghost changed the title implicit erasure code crush ruleset is not validated mon: implicit erasure code crush ruleset is not validated Sep 13, 2015

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.