New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

librbd: add valgrind memory checks for unit tests #5280

Merged
11 commits merged into from Jul 28, 2015

Conversation

Projects
None yet
3 participants
@dillaman
Contributor

dillaman commented Jul 17, 2015

wonzhq and others added some commits Mar 20, 2015

test: potential memory leak in FlushAioPP
Should call the release function instead of deleting it to free
librbd::RBD::AioCompletion and librbd::AioCompletion. Otherwise there is
a potential memory leak.

Signed-off-by: Zhiqiang Wang <zhiqiang.wang@intel.com>
(cherry picked from commit ada7ec8)
librados_test_stub: cleanup singleton memory allocation
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit 54c8825)
tests: librbd should release global data before exit
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit 6ab1bb5)
tests: fix valgrind errors with librbd unit test
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit ed5472a)
librbd: TaskFinisher should finish all queued tasks
The destructor wasn't waiting for all Finisher tasks
to complete before stopping the thread.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit 8e20240)
valgrind: update valgrind suppressions for lttng-ust
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit 8d87bdf)
tests: add run-rbd-valgrind-unit-tests.sh
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit 5534faa)
fsx: cleanup crypto library at exit
Also made small tweaks so that it can be compiled under
a C++ compiler.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit c44f8e7)
krbd: fix incorrect types in the krbd API
The C API functions were referencing the C++ CephContext
instead of the C rados_config_t.  Additionally, the ceph
namespace was missing on the Formatter class.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit 740fd27)
osdc: invalid read of freed memory
The bytes not in cache stat was potentially reading the bh length
from a deleted bufferhead.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit 5ccc442)
pybind: fix valgrind warning on rbd_get_parent_info call
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit 2586e3b)

@dillaman dillaman added this to the hammer milestone Jul 17, 2015

ghost pushed a commit that referenced this pull request Jul 19, 2015

Merge pull request #5280: librbd: add valgrind memory checks for unit…
… tests

Reviewed-by: Loic Dachary <ldachary@redhat.com>

ghost pushed a commit that referenced this pull request Jul 19, 2015

Merge pull request #5280: librbd: add valgrind memory checks for unit…
… tests

Reviewed-by: Loic Dachary <ldachary@redhat.com>

ghost pushed a commit that referenced this pull request Jul 19, 2015

Merge pull request #5280: librbd: add valgrind memory checks for unit…
… tests

Reviewed-by: Loic Dachary <ldachary@redhat.com>

ghost pushed a commit that referenced this pull request Jul 19, 2015

Merge pull request #5280: librbd: add valgrind memory checks for unit…
… tests

Reviewed-by: Loic Dachary <ldachary@redhat.com>

ghost pushed a commit that referenced this pull request Jul 19, 2015

Merge pull request #5280: librbd: add valgrind memory checks for unit…
… tests

Reviewed-by: Loic Dachary <ldachary@redhat.com>

@ghost ghost self-assigned this Jul 28, 2015

@ghost

This comment has been minimized.

ghost commented Jul 28, 2015

It went through a rbd suite ( http://tracker.ceph.com/issues/11990#rbd ).

ghost pushed a commit that referenced this pull request Jul 28, 2015

Loic Dachary
Merge pull request #5280 from ceph/wip-12384-hammer
librbd: add valgrind memory checks for unit tests

Reviewed-by: Loic Dachary <ldachary@redhat.com>

@ghost ghost merged commit 6b6228f into hammer Jul 28, 2015

@dillaman dillaman deleted the wip-12384-hammer branch Sep 7, 2015

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment