New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: radosgw-admin dumps user info twice #5286

Merged
1 commit merged into from Jul 31, 2015

Conversation

Projects
None yet
3 participants
@smithfarm
Contributor

smithfarm commented Jul 19, 2015

Fixes: #12286 radosgw-admin: after subuser modify print only once use…
…r info.

remove rgw_admin.cc OPT_SUBUSER_MODIFY, show_user_info code block.

switch (opt_cmd) {
...
case OPT_SUBUSER_MODIFY:
show_user_info(info, formatter);       //show first time (remove this)
break;
...
}

// output the result of a user operation
if (output_user_info) {
...
show_user_info(info, formatter);       //show second time
}

test fix:
before: after subuser modify print twice user info.
after changes, do the same procedure, print only once user info.

Signed-off-by: guce guce@h3c.com
(cherry picked from commit c604dd9)

@smithfarm smithfarm self-assigned this Jul 19, 2015

@smithfarm smithfarm added this to the hammer milestone Jul 19, 2015

@smithfarm smithfarm added bug fix core rgw and removed core labels Jul 19, 2015

@smithfarm smithfarm assigned theanalyst and unassigned smithfarm Jul 19, 2015

ghost pushed a commit that referenced this pull request Jul 19, 2015

Merge pull request #5286: rgw: radosgw-admin dumps user info twice
Reviewed-by: Loic Dachary <ldachary@redhat.com>
@ghost

This comment has been minimized.

ghost commented Jul 28, 2015

@yehudasa does this hammer backport looks good to merge ? It went through a rgw suite ( http://tracker.ceph.com/issues/11990#rgw ), only one job failed because of a radosgw-agent failure specific to Ubuntu 12.04 (but succeded on 14.04).

ghost pushed a commit that referenced this pull request Jul 29, 2015

ghost pushed a commit that referenced this pull request Jul 31, 2015

Loic Dachary
Merge pull request #5286 from SUSE/wip-12400-hammer
rgw: radosgw-admin dumps user info twice

Reviewed-by: Yehuda Sadeh <ysadehwe@redhat.com>

@ghost ghost merged commit 5cbb6cf into ceph:hammer Jul 31, 2015

@smithfarm smithfarm deleted the SUSE:wip-12400-hammer branch Jul 31, 2015

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment