Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

radosgw-admin: Create --secret-key alias for --secret #5335

Merged
merged 1 commit into from Oct 15, 2015

Conversation

Projects
None yet
5 participants
@zhouyuan
Copy link
Contributor

zhouyuan commented Jul 24, 2015

Fixes: #5821

Signed-off-by: Yuan Zhou yuan.zhou@intel.com

@tchaikov

This comment has been minimized.

Copy link
Contributor

tchaikov commented Jul 24, 2015

nit pick: the typo in the title. =)

@zhouyuan zhouyuan force-pushed the zhouyuan:radosgw_admin_secret_key_alias branch from 58c9c1a to 5db5825 Jul 25, 2015

@zhouyuan zhouyuan changed the title radosgw-admin: Create --secrte-key alias for --secret radosgw-admin: Create --secret-key alias for --secret Jul 25, 2015

@zhouyuan

This comment has been minimized.

Copy link
Contributor Author

zhouyuan commented Jul 25, 2015

@tchaikov Thanks! It's fixed now.

@@ -1172,7 +1173,7 @@ int main(int argc, char **argv)
access_key = val;
} else if (ceph_argparse_witharg(args, i, &val, "--subuser", (char*)NULL)) {
subuser = val;
} else if (ceph_argparse_witharg(args, i, &val, "--secret", (char*)NULL)) {
} else if (ceph_argparse_witharg(args, i, &val, "--secret", "--secrte-key", (char*)NULL)) {
secret_key = val;

This comment has been minimized.

@theanalyst

theanalyst Jul 28, 2015

Member

typo "--secret-key"

This comment has been minimized.

@zhouyuan

zhouyuan Jul 28, 2015

Author Contributor

@theanalyst thank you! fixed.

@zhouyuan zhouyuan force-pushed the zhouyuan:radosgw_admin_secret_key_alias branch 3 times, most recently from e446c15 to a10bce0 Jul 28, 2015

@theanalyst

This comment has been minimized.

Copy link
Member

theanalyst commented Jul 29, 2015

LGTM

@yehudasa

This comment has been minimized.

Copy link
Member

yehudasa commented Aug 5, 2015

@zhouyuan there's a merge conflict, I can't merge it, can you rebase it? Thanks

radosgw-admin: Create --secret-key alias for --secret
Fixes: #5821
Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>

@zhouyuan zhouyuan force-pushed the zhouyuan:radosgw_admin_secret_key_alias branch from a10bce0 to 2938fdd Aug 7, 2015

@zhouyuan

This comment has been minimized.

Copy link
Contributor Author

zhouyuan commented Aug 7, 2015

@yehudasa rebased on the master. Thanks for the review!

@ghost

This comment has been minimized.

Copy link

ghost commented Aug 7, 2015

@zhouyuan please ignore the bot failure, this is a false negative ( http://tracker.ceph.com/issues/12340 ).

yehudasa added a commit that referenced this pull request Oct 15, 2015

Merge pull request #5335 from zhouyuan/radosgw_admin_secret_key_alias
radosgw-admin: Create --secret-key alias for --secret

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>

@yehudasa yehudasa merged commit c55f8d4 into ceph:master Oct 15, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.