Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crush: ceph osd crush reweight-subtree does not reweight parent node #5374

Merged
6 commits merged into from Aug 30, 2015

Conversation

Projects
None yet
2 participants
@ghost
Copy link

ghost commented Jul 28, 2015

liewegas added some commits Jun 5, 2015

unittest_crush_wrapper: parse env
Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit 14c60b2)
unittest_crush_wrapper: test adjust_subtree_weight
Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit b461dc2)
crush/CrushWrapper: adjust subtree base in adjust_subtree_weight
We were correctly adjusting all the children, but the subtree root was
not being updated.

Fixes: #11855
Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit 1da96ab)
unittest_crush_wrapper: attach buckets to root in adjust_item_weight …
…test

Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit a8351eb)
crush/CrushWrapper: return changed from adjust_subtree_weight
Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit 551ab2d)
crush/CrushWrapper: fix adjust_subtree_weight debug
Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit 26be86f)

@ghost ghost self-assigned this Jul 28, 2015

@ghost ghost added this to the hammer milestone Jul 28, 2015

@ghost ghost added bug fix core labels Jul 28, 2015

ghost pushed a commit that referenced this pull request Jul 29, 2015

@ghost

This comment has been minimized.

Copy link
Author

ghost commented Aug 30, 2015

@liewegas does this backport look good to merge ? It passed a run of the hammer rados suite ( see http://tracker.ceph.com/issues/12701#rados for details ).

@liewegas

This comment has been minimized.

Copy link
Member

liewegas commented Aug 30, 2015

👍

ghost pushed a commit that referenced this pull request Aug 30, 2015

Merge pull request #5374: ceph osd crush reweight-subtree does not re…
…weight parent node

Reviewed-by: Loic Dachary <ldachary@redhat.com>

ghost pushed a commit that referenced this pull request Aug 30, 2015

Loic Dachary
Merge pull request #5374 from dachary/wip-12487-hammer
ceph osd crush reweight-subtree does not reweight parent node

Reviewed-by: Sage Weil <sage@redhat.com>

@ghost ghost merged commit d3b160e into ceph:hammer Aug 30, 2015

@ghost ghost changed the title ceph osd crush reweight-subtree does not reweight parent node crush: ceph osd crush reweight-subtree does not reweight parent node Sep 13, 2015

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.