New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mon: EC pools are not allowed as cache pools, disallow in the mon #5389

Merged
1 commit merged into from Sep 4, 2015

Conversation

Projects
None yet
3 participants
@smithfarm
Contributor

smithfarm commented Jul 28, 2015

@smithfarm smithfarm self-assigned this Jul 28, 2015

@smithfarm smithfarm added this to the firefly milestone Jul 28, 2015

OSDMonitor: disallow ec pools as tiers
Fixes: 11650
Signed-off-by: Samuel Just <sjust@redhat.com>
(cherry picked from commit 11b7801)

Conflicts:
	qa/workunits/cephtool/test.sh
           no "# make sure we can't clobber snapshot state" tests in firefly
	src/mon/OSDMonitor.cc
           no tp->removed_snaps.empty() in firefly
@smithfarm

This comment has been minimized.

Contributor

smithfarm commented Sep 4, 2015

@athanatos This has passed a rados suite (see http://tracker.ceph.com/issues/11644#rados for details). OK to merge, do you think?

@smithfarm

This comment has been minimized.

Contributor

smithfarm commented Sep 4, 2015

@dachary Seeing as Sam is out, could you take a look?

@ghost

This comment has been minimized.

ghost commented Sep 4, 2015

yeah, that's simple enough :-)

ghost pushed a commit that referenced this pull request Sep 4, 2015

Loic Dachary
Merge pull request #5389 from SUSE/wip-12391-firefly
EC pools are not allowed as cache pools, disallow in the mon

Reviewed-by: Loic Dachary <ldachary@redhat.com>

@ghost ghost merged commit 055624b into ceph:firefly Sep 4, 2015

@smithfarm smithfarm deleted the SUSE:wip-12391-firefly branch Sep 4, 2015

smithfarm added a commit to SUSE/ceph that referenced this pull request Sep 5, 2015

mon: prevent pool with snapshot state from being used as a tier
If we add a pool with snap state as a tier the snap state gets clobbered
by OSDMap::Incremental::propogate_snaps_to_tiers(), and may prevent OSDs
from starting.  Disallow this.

Include a test.

Fixes: ceph#11493
Backport: hammer, giant, firefly
Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit bbec53e)

Conflicts:
	qa/workunits/cephtool/test.sh
           properly co-exist with "# make sure we can't create an ec pool tier"
	src/mon/OSDMonitor.cc
           properly co-exist with preceding "if (tp->ec_pool())"
        (The changes to both files would have applied cleanly if
        ceph#5389 had not been merged first.)

smithfarm added a commit to SUSE/ceph that referenced this pull request Oct 5, 2015

mon: prevent pool with snapshot state from being used as a tier
If we add a pool with snap state as a tier the snap state gets clobbered
by OSDMap::Incremental::propogate_snaps_to_tiers(), and may prevent OSDs
from starting.  Disallow this.

Include a test.

Fixes: ceph#11493
Backport: hammer, giant, firefly
Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit bbec53e)

Conflicts:
	qa/workunits/cephtool/test.sh
           properly co-exist with "# make sure we can't create an ec pool tier"
	src/mon/OSDMonitor.cc
           properly co-exist with preceding "if (tp->ec_pool())"
        (The changes to both files would have applied cleanly if
        ceph#5389 had not been merged first.)

smithfarm added a commit to SUSE/ceph that referenced this pull request Oct 8, 2015

mon: prevent pool with snapshot state from being used as a tier
If we add a pool with snap state as a tier the snap state gets clobbered
by OSDMap::Incremental::propogate_snaps_to_tiers(), and may prevent OSDs
from starting.  Disallow this.

Include a test.

Fixes: ceph#11493
Backport: hammer, giant, firefly
Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit bbec53e)

Conflicts:
	qa/workunits/cephtool/test.sh
           properly co-exist with "# make sure we can't create an ec pool tier"
	src/mon/OSDMonitor.cc
           properly co-exist with preceding "if (tp->ec_pool())"
        (The changes to both files would have applied cleanly if
        ceph#5389 had not been merged first.)

@ghost ghost changed the title from EC pools are not allowed as cache pools, disallow in the mon to mon: EC pools are not allowed as cache pools, disallow in the mon Oct 24, 2015

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment