New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: logrotate.conf calls service with wrong init script name #5390

Merged
merged 1 commit into from Aug 12, 2015

Conversation

Projects
None yet
4 participants
@smithfarm
Contributor

smithfarm commented Jul 28, 2015

rgw/logrotate.conf: Rename service name
The service name for ceph rados gateway was changed to "ceph-radosgw",
the previous version of service name "radosgw" would cause a failed reload,
and finally make it impossible to write any log data to the log file.

Signed-off-by: wuxingyi <wuxingyi2015@outlook.com>
(cherry picked from commit 9df3f79)

@smithfarm smithfarm self-assigned this Jul 28, 2015

@smithfarm smithfarm added this to the firefly milestone Jul 28, 2015

@smithfarm smithfarm added bug fix core rgw and removed core labels Jul 28, 2015

@smithfarm

This comment has been minimized.

Contributor

smithfarm commented Aug 11, 2015

@dachary This PR is classified as rgw, but I don't think any of the suites we are running actually test logrotate. How do you think we should proceed?

@ghost

This comment has been minimized.

ghost commented Aug 11, 2015

@smithfarm I would just ask for approval. Maybe the upgrade suite does some logrotate when upgrading ?

@smithfarm

This comment has been minimized.

Contributor

smithfarm commented Aug 11, 2015

@ktdreyer This is a backport of #3953. It is included in the integration tests that are currently running - see http://tracker.ceph.com/issues/11644. I am uncertain whether any of these tests are relevant to this PR, however. Assuming the integration tests are green, do you think this is OK to merge?

@ktdreyer

This comment has been minimized.

Member

ktdreyer commented Aug 11, 2015

Yeah, I don't think the integration tests cover this :(

@ktdreyer

This comment has been minimized.

Member

ktdreyer commented Aug 11, 2015

it's fine to merge it

smithfarm added a commit that referenced this pull request Aug 12, 2015

Merge pull request #5390 from SUSE/wip-12503-firefly
rgw/logrotate.conf calls service with wrong init script name

Reviewed-by: Ken Dreyer <kdreyer@redhat.com>

@smithfarm smithfarm merged commit ea601ef into ceph:firefly Aug 12, 2015

@smithfarm smithfarm deleted the SUSE:wip-12503-firefly branch Aug 12, 2015

@ghost ghost changed the title from rgw/logrotate.conf calls service with wrong init script name to rgw: logrotate.conf calls service with wrong init script name Oct 24, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment