Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: log: take mutex while opening fd #5406

Merged
merged 1 commit into from Sep 4, 2015

Conversation

Projects
None yet
4 participants
@liewegas
Copy link
Member

commented Jul 29, 2015

Log::reopen_log_file: take m_flush_mutex
Otherwise, _flush() might continue to write to m_fd after it's closed.
This might cause log data to go to a data object if the filestore then
reuses the fd during that time.

Fixes: #12465
Backport: firefly, hammer
Signed-off-by: Samuel Just <sjust@redhat.com>
(cherry picked from commit 8778ab3)

  - modified to drop m_flush_mutex_holder, which isn't present in firefly

@liewegas liewegas added this to the firefly milestone Jul 29, 2015

@ghost ghost self-assigned this Aug 29, 2015

@smithfarm

This comment has been minimized.

Copy link
Contributor

commented Sep 4, 2015

@liewegas This has passed a rados suite (see http://tracker.ceph.com/issues/11644#rados for details). OK to merge, do you think?

liewegas added a commit that referenced this pull request Sep 4, 2015

Merge pull request #5406 from ceph/wip-12465-firefly
log: take mutex while opening fd

Reviewed-by: Sage Weil <sage@redhat.com>

@liewegas liewegas merged commit 045c056 into firefly Sep 4, 2015

@liewegas

This comment has been minimized.

Copy link
Member Author

commented Sep 4, 2015

thanks!

@liewegas liewegas deleted the wip-12465-firefly branch Sep 4, 2015

@ghost ghost changed the title log: take mutex while opening fd common: log: take mutex while opening fd Oct 24, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.