New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd: crash creating/deleting pools #5526

Merged
1 commit merged into from Oct 22, 2015

Conversation

Projects
None yet
3 participants
@smithfarm
Contributor

smithfarm commented Aug 10, 2015

osd/OSDMap: handle incrementals that modify+del pool
Because new_pools was processed after old_pools, if something
was modified and then deleted in the same incremental
map, then the resulting state would be a pool in the map
that had no entry in pool_name.

Fixes: #12429
Signed-off-by: John Spray <john.spray@redhat.com>
(cherry picked from commit 8d4932e)

@smithfarm smithfarm self-assigned this Aug 10, 2015

@smithfarm smithfarm added this to the firefly milestone Aug 10, 2015

@smithfarm smithfarm changed the title from OSD crash creating/deleting pools to [DNM] OSD crash creating/deleting pools Aug 10, 2015

@smithfarm smithfarm changed the title from [DNM] OSD crash creating/deleting pools to OSD crash creating/deleting pools Aug 11, 2015

ghost pushed a commit that referenced this pull request Oct 20, 2015

Merge pull request #5526: OSD crash creating/deleting pools
Reviewed-by: Loic Dachary <ldachary@redhat.com>
@ghost

This comment has been minimized.

ghost commented Oct 20, 2015

@tchaikov does this backport look good to merge ? It passed a run of the firefly rados suite ( see http://tracker.ceph.com/issues/11644#note-110 ). Note that there was a valgrind issues but it is unrelated and fixed by #6325.

ghost pushed a commit that referenced this pull request Oct 21, 2015

Merge pull request #5526: OSD crash creating/deleting pools
Reviewed-by: Loic Dachary <ldachary@redhat.com>
@athanatos

This comment has been minimized.

Contributor

athanatos commented Oct 21, 2015

Looks ok to me.

ghost pushed a commit that referenced this pull request Oct 22, 2015

Loic Dachary
Merge pull request #5526 from SUSE/wip-12584-firefly
OSD crash creating/deleting pools

Reviewed-by: Samuel Just <sjust@redhat.com>

@ghost ghost merged commit 15f3628 into ceph:firefly Oct 22, 2015

@smithfarm smithfarm deleted the SUSE:wip-12584-firefly branch Oct 22, 2015

@ghost ghost changed the title from OSD crash creating/deleting pools to osd: crash creating/deleting pools Oct 24, 2015

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment