New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: swift smoke test fails on TestAccountUTF8 #5532

Merged
merged 7 commits into from Oct 22, 2015

Conversation

Projects
None yet
6 participants

@smithfarm smithfarm self-assigned this Aug 10, 2015

@smithfarm smithfarm added this to the firefly milestone Aug 10, 2015

@smithfarm smithfarm added bug fix core rgw and removed core labels Aug 10, 2015

@smithfarm smithfarm changed the title from swift smoke test fails on TestAccountUTF8 to [DNM] swift smoke test fails on TestAccountUTF8 Aug 10, 2015

@smithfarm smithfarm changed the title from [DNM] swift smoke test fails on TestAccountUTF8 to swift smoke test fails on TestAccountUTF8 Aug 11, 2015

@smithfarm smithfarm changed the title from swift smoke test fails on TestAccountUTF8 to [DNM] swift smoke test fails on TestAccountUTF8 Sep 26, 2015

@smithfarm smithfarm changed the title from [DNM] swift smoke test fails on TestAccountUTF8 to swift smoke test fails on TestAccountUTF8 Oct 5, 2015

@smithfarm

This comment has been minimized.

Contributor

smithfarm commented Oct 5, 2015

@dachary Revamped using #5718 as a model

oritwas and others added some commits Apr 9, 2015

rgw: shouldn't return content-type: application/xml if content length…
… is 0

Fixed: #11091

Signed-off-by: Orit Wasserman <owasserm@redhat.com>
(cherry picked from commit 5cc92bb)
rgw: force content-type header for swift account responses without body
This regression was introduced in commit 4cfeca0

Fixes: #11438

Signed-off-by: Orit Wasserman <owasserm@redhat.com>
(cherry picked from commit 009664e)
rgw: force content_type for swift bucket stats request
Fixes: 12095

Signed-off-by: Orit Wasserman <owasserm@redhat.com>
(cherry picked from commit da259e4)
rgw: enforce Content-Type in Swift responses.
Swift sends Content-Type HTTP header even if the response
doesn't contain body. We have this behaviour implemented
until applying some changes in end_header() function.
Unfortunately, lack of Content-Type causes early exits in
many Tempest's tests for Swift API verification.

Fixes: #12157
Signed-off-by: Radoslaw Zarzynski <rzarzynski@mirantis.com>
(cherry picked from commit 106aeba)

rzarzynski and others added some commits Jun 25, 2015

rgw: send Content-Length in response for GET on Swift account.
Fixes: #12158
Signed-off-by: Radoslaw Zarzynski <rzarzynski@mirantis.com>
(cherry picked from commit 5f47b11)

Conflicts:
	src/rgw/rgw_rest_swift.cc
            omit dump_account_metadata() call
rgw: we should not overide Swift sent content type
Fixes: #12363
backport: hammer

Signed-off-by: Orit Wasserman <owasserm@redhat.com>
(cherry picked from commit 423cf13)
Fix casing of Content-Type header
It turns out, despite the HTTP spec declaring that header field names
should be case-insensitive, some clients treat them wrongly, and
consider "Content-type" to not match "Content-Type".

CyberDuck was one of those clients, now fixed upstream in
https://trac.cyberduck.io/ticket/8999

To reduce future occurances of this bug, fix the casing of the
Content-Type header, to strictly comply with the HTTP specification (be
strict about what you send, and generous about what you receive).

Fixes: #12939
Backport: hammer, firefly
Signed-off-by: Robin H. Johnson <robin.johnson@dreamhost.com>
(cherry picked from commit 1b9fbff)
@smithfarm

This comment has been minimized.

Contributor

smithfarm commented Oct 8, 2015

Rebased and repushed. Waiting for bot.

ghost pushed a commit that referenced this pull request Oct 20, 2015

Merge pull request #5532: swift smoke test fails on TestAccountUTF8
Reviewed-by: Loic Dachary <ldachary@redhat.com>
@ghost

This comment has been minimized.

ghost commented Oct 20, 2015

@yehudasa does this backport look good to merge ? It passed a run of the firefly rgw suite ( see http://tracker.ceph.com/issues/11644#note-111 ). Note that there were two valgrind issues but they are unrelated and fixed by #6325.

ghost pushed a commit that referenced this pull request Oct 21, 2015

Merge pull request #5532: swift smoke test fails on TestAccountUTF8
Reviewed-by: Loic Dachary <ldachary@redhat.com>

yehudasa added a commit that referenced this pull request Oct 22, 2015

Merge pull request #5532 from SUSE/wip-12635-firefly
swift smoke test fails on TestAccountUTF8

@yehudasa yehudasa merged commit eaf7dc3 into ceph:firefly Oct 22, 2015

@smithfarm smithfarm deleted the SUSE:wip-12635-firefly branch Oct 22, 2015

@ghost ghost changed the title from swift smoke test fails on TestAccountUTF8 to rgw: swift smoke test fails on TestAccountUTF8 Oct 24, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment