New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: ceph-disk: sometimes the journal symlink is not created #5541

Merged
2 commits merged into from Oct 20, 2015

Conversation

Projects
None yet
3 participants
@ghost

ghost commented Aug 11, 2015

dvanders added some commits Sep 29, 2014

ceph-disk: set guid if reusing a journal partition
When reusing a journal partition (e.g. /dev/sda2) we should set a
new partition guid and link it correctly with the OSD. This way
the journal is symlinked by its persistent name and ceph-disk list
works correctly.

Signed-off-by: Dan van der Ster <daniel.vanderster@cern.ch>
(cherry picked from commit beff616)
ceph-disk: don't change the journal partition uuid
We observe that the new /dev/disk/by-partuuid/<journal_uuid>
symlink is not always created by udev when reusing a journal
partition. Fix by not changing the uuid of a journal partition
in this case -- instead we can reuse the existing uuid (and
journal_symlink) instead. We also now assert that the symlink
exists before further preparing the OSD.

Fixes: #10146
Signed-off-by: Dan van der Ster <daniel.vanderster@cern.ch>
Tested-by: Dan van der Ster <daniel.vanderster@cern.ch>
(cherry picked from commit 29eb135)

@ghost ghost self-assigned this Aug 11, 2015

@ghost ghost added this to the firefly milestone Aug 11, 2015

@ghost ghost added bug fix rgw labels Aug 11, 2015

@smithfarm smithfarm added core and removed rgw labels Sep 4, 2015

ghost pushed a commit that referenced this pull request Oct 20, 2015

Merge pull request #5541: ceph-disk: sometimes the journal symlink is…
… not created

Reviewed-by: Loic Dachary <ldachary@redhat.com>

ghost pushed a commit that referenced this pull request Oct 20, 2015

Loic Dachary
Merge pull request #5541 from dachary/wip-12418-firefly
ceph-disk: sometimes the journal symlink is not created

Reviewed-by: Loic Dachary <ldachary@redhat.com>

@ghost ghost merged commit 6240b61 into ceph:firefly Oct 20, 2015

@ghost ghost changed the title from ceph-disk: sometimes the journal symlink is not created to tools: ceph-disk: sometimes the journal symlink is not created Oct 24, 2015

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment