New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: RGW returns requested bucket name raw in "Bucket" response header #5730

Merged
2 commits merged into from Oct 20, 2015

Conversation

Projects
None yet
4 participants

wido and others added some commits Jun 3, 2015

rgw: Do not enclose the Bucket header in quotes
Fixes: #11860
Signed-off-by: Wido den Hollander <wido@42on.com>
(cherry picked from commit 8af25fa)
rgw: url encode exposed bucket
Fixes: #12537
Don't send the bucket name back without url encoding it.

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>
(cherry picked from commit ad5507f)

@yehudasa yehudasa added this to the firefly milestone Aug 31, 2015

@smithfarm

This comment has been minimized.

Contributor

smithfarm commented Sep 4, 2015

@yehudasa The first commit in this PR, 558c529, is duplicated by #4861 - how do you suggest we proceed? I see two possibilities: ( close #4861 and merge this PR ) or ( merge #4861 and rebase this PR )

@ghost

This comment has been minimized.

ghost commented Sep 4, 2015

@smithfarm you could also merge #4861 first and this one next, without rebasing. The extra commit will be silently discarded.

@smithfarm

This comment has been minimized.

Contributor

smithfarm commented Sep 4, 2015

@dachary Cool! Sounds like a plan.

@ghost ghost changed the title from Wip 12537 firefly to RGW returns requested bucket name raw in "Bucket" response header Sep 6, 2015

ghost pushed a commit that referenced this pull request Oct 20, 2015

Merge pull request #5730: RGW returns requested bucket name raw in "B…
…ucket" response header

Reviewed-by: Loic Dachary <ldachary@redhat.com>

ghost pushed a commit that referenced this pull request Oct 20, 2015

Loic Dachary
Merge pull request #5730 from ceph/wip-12537-firefly
RGW returns requested bucket name raw in "Bucket" response header

Reviewed-by: Loic Dachary <ldachary@redhat.com>

@ghost ghost merged commit 3e0e3c5 into firefly Oct 20, 2015

@ghost ghost self-assigned this Oct 20, 2015

@smithfarm smithfarm deleted the wip-12537-firefly branch Oct 20, 2015

@ghost ghost changed the title from RGW returns requested bucket name raw in "Bucket" response header to rgw: RGW returns requested bucket name raw in "Bucket" response header Oct 24, 2015

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment