New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: ceph-disk zap should ensure block device #5755

Merged
1 commit merged into from Sep 2, 2015

Conversation

Projects
None yet
2 participants
@ghost

ghost commented Sep 2, 2015

ceph-disk: always check zap is applied on a full device
zap only makes sense on a full device and this is verified for

    ceph-disk prepare --zap-disk

but not for

    ceph-disk zap

Unify the two and add a test to check that it fails as expected when
trying to zap a directory.

http://tracker.ceph.com/issues/11272 Fixes: #11272

Signed-off-by: Loic Dachary <ldachary@redhat.com>
(cherry picked from commit 8e1bcf2)

Conflicts:
	src/test/ceph-disk.sh : trivial resolution

@ghost ghost self-assigned this Sep 2, 2015

@ghost ghost added this to the hammer milestone Sep 2, 2015

@ghost ghost added bug fix core labels Sep 2, 2015

ghost pushed a commit that referenced this pull request Sep 2, 2015

Merge pull request #5755: ceph-disk zap should ensure block device
Reviewed-by: Loic Dachary <ldachary@redhat.com>
@ghost

This comment has been minimized.

ghost commented Sep 2, 2015

The ceph-deploy suite successfully ran two CentOS 6.5 jobs at http://tracker.ceph.com/issues/12701#note-65. The other two failed with what appears to be a problem with dmcrypt (HEALTH_ERR clock skew detected on mon.vpm158; 64 pgs stuck inactive; 64 pgs stuck unclean; no osds; Monitor clock skew detected) that is unrelated to this pull request.

ghost pushed a commit that referenced this pull request Sep 2, 2015

Loic Dachary
Merge pull request #5755 from dachary/wip-12589-hammer
ceph-disk zap should ensure block device

Reviewed-by: Loic Dachary <ldachary@redhat.com>

@ghost ghost merged commit fa74ea1 into ceph:hammer Sep 2, 2015

@ghost ghost changed the title from ceph-disk zap should ensure block device to tools: ceph-disk zap should ensure block device Sep 13, 2015

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment