New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd: PGLog.cc: 732: FAILED assert(log.log.size() == log_keys_debug.size()) #5763

Merged
1 commit merged into from Sep 7, 2015

Conversation

Projects
None yet
2 participants
@ghost

ghost commented Sep 2, 2015

@ghost ghost self-assigned this Sep 2, 2015

@ghost ghost added this to the hammer milestone Sep 2, 2015

@ghost ghost added bug fix core labels Sep 2, 2015

ghost pushed a commit that referenced this pull request Sep 2, 2015

Merge pull request #5763: osd/PGLog.cc: 732: FAILED assert(log.log.si…
…ze() == log_keys_debug.size())

Reviewed-by: Loic Dachary <ldachary@redhat.com>
osd/PGLog: dirty_to is inclusive
There are only two callers of mark_dirty_to who do not pass max,
and they are both in the merge_log extending tail path.  In that
case, we want to include the last version specified in the log
writeout.  Fix the tail extending code to always specify the
last entry added, inclusive.

Fixes: #12652
Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit f0ca14d)
@ghost

This comment has been minimized.

ghost commented Sep 6, 2015

@liewegas this hammer backport passed a rados suite (see http://tracker.ceph.com/issues/12701#note-62 for the details). Do you think it is ready to be merged ?

@ghost ghost assigned liewegas and unassigned ghost Sep 6, 2015

@liewegas

This comment has been minimized.

Member

liewegas commented Sep 7, 2015

👍

ghost pushed a commit that referenced this pull request Sep 7, 2015

Loic Dachary
Merge pull request #5763 from dachary/wip-12846-hammer
osd/PGLog.cc: 732: FAILED assert(log.log.size() == log_keys_debug.size())

Reviewed-by: Sage Weil <sage@redhat.com>

@ghost ghost merged commit 8ccb771 into ceph:hammer Sep 7, 2015

@ghost ghost changed the title from osd/PGLog.cc: 732: FAILED assert(log.log.size() == log_keys_debug.size()) to osd: PGLog.cc: 732: FAILED assert(log.log.size() == log_keys_debug.size()) Sep 13, 2015

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment