Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: recursive lock of md_config_t (0) #5814

Merged
1 commit merged into from Oct 20, 2015

Conversation

Projects
None yet
4 participants
@smithfarm
Copy link
Contributor

commented Sep 4, 2015

config: skip lockdep for intentionally recursive md_config_t lock
lockdep can't handle recursive locks, resulting in false positive
reports for certain set_val_or_die() calls, like via
md_config_t::parse_argv() passed "-m".

Fixes: #12614
Signed-off-by: Josh Durgin <jdurgin@redhat.com>
(cherry picked from commit 4152269)

@smithfarm smithfarm self-assigned this Sep 4, 2015

@smithfarm smithfarm added this to the firefly milestone Sep 4, 2015

@smithfarm smithfarm added bug fix core common and removed core labels Sep 4, 2015

ghost pushed a commit that referenced this pull request Oct 20, 2015

Merge pull request #5814: recursive lock of md_config_t (0)
Reviewed-by: Loic Dachary <ldachary@redhat.com>
@ghost

This comment has been minimized.

Copy link

commented Oct 20, 2015

@liewegas does this backport look good to merge ? It passed a run of the firefly rados suite ( see http://tracker.ceph.com/issues/11644#note-110 ). Note that there was a valgrind issues but it is unrelated and fixed by #6325.

@liewegas

This comment has been minimized.

Copy link
Member

commented Oct 20, 2015

👍

ghost pushed a commit that referenced this pull request Oct 20, 2015

Loic Dachary
Merge pull request #5814 from SUSE/wip-12840-firefly
recursive lock of md_config_t (0)

Reviewed-by: Sage Weil <sage@redhat.com>

@ghost ghost merged commit e43d049 into ceph:firefly Oct 20, 2015

@smithfarm smithfarm deleted the SUSE:wip-12840-firefly branch Oct 20, 2015

@ghost ghost changed the title recursive lock of md_config_t (0) common: recursive lock of md_config_t (0) Oct 24, 2015

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.