Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd: Mutex Assert from PipeConnection::try_get_pipe #5815

Merged
1 commit merged into from Oct 23, 2015

Conversation

Projects
None yet
4 participants
@smithfarm
Copy link
Contributor

commented Sep 4, 2015

@smithfarm smithfarm self-assigned this Sep 4, 2015

@smithfarm smithfarm added this to the firefly milestone Sep 4, 2015

osd: Keep a reference count on Connection while calling send_message()
Fixes: #12437

Signed-off-by: David Zafman <dzafman@redhat.com>
(manual backport of commit a140085)

Conflicts:      src/osd/OSD.cc
                   master has share_map_peer; firefly has osd->_share_map_outgoing

@smithfarm smithfarm force-pushed the SUSE:wip-12838-firefly branch from 11cf8d6 to f39c791 Sep 5, 2015

ghost pushed a commit that referenced this pull request Oct 20, 2015

Merge pull request #5815: Mutex Assert from PipeConnection::try_get_pipe
Reviewed-by: Loic Dachary <ldachary@redhat.com>
@ghost

This comment has been minimized.

Copy link

commented Oct 20, 2015

@athanatos does this backport look good to merge ? It passed a run of the firefly rados suite ( see http://tracker.ceph.com/issues/11644#note-110 ). Note that there was a valgrind issues but it is unrelated and fixed by #6325.

ghost pushed a commit that referenced this pull request Oct 21, 2015

Merge pull request #5815: Mutex Assert from PipeConnection::try_get_pipe
Reviewed-by: Loic Dachary <ldachary@redhat.com>
@athanatos

This comment has been minimized.

Copy link
Contributor

commented Oct 22, 2015

I'll run this one by david since there was a conflict.

@ghost

This comment has been minimized.

Copy link

commented Oct 22, 2015

@athanatos ok ! @dzafman what do you think ?

@ghost ghost assigned dzafman and unassigned smithfarm Oct 22, 2015

@dzafman

This comment has been minimized.

Copy link
Member

commented Oct 22, 2015

👍 The different function names actually identical.

ghost pushed a commit that referenced this pull request Oct 23, 2015

Loic Dachary
Merge pull request #5815 from SUSE/wip-12838-firefly
Mutex Assert from PipeConnection::try_get_pipe

Reviewed-by: David Zafman <dzafman@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>

@ghost ghost merged commit 241edfa into ceph:firefly Oct 23, 2015

@smithfarm smithfarm deleted the SUSE:wip-12838-firefly branch Oct 23, 2015

@ghost ghost changed the title Mutex Assert from PipeConnection::try_get_pipe osd: Mutex Assert from PipeConnection::try_get_pipe Oct 24, 2015

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.