New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd: osd/PGLog.cc: 732: FAILED assert(log.log.size() == log_keys_debug.size()) #5820

Merged
1 commit merged into from Oct 20, 2015

Conversation

Projects
None yet
3 participants
@smithfarm
Contributor

smithfarm commented Sep 5, 2015

osd/PGLog: dirty_to is inclusive
There are only two callers of mark_dirty_to who do not pass max,
and they are both in the merge_log extending tail path.  In that
case, we want to include the last version specified in the log
writeout.  Fix the tail extending code to always specify the
last entry added, inclusive.

Fixes: #12652
Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit f0ca14d)

@smithfarm smithfarm self-assigned this Sep 5, 2015

@smithfarm smithfarm added this to the firefly milestone Sep 5, 2015

ghost pushed a commit that referenced this pull request Oct 20, 2015

Merge pull request #5820: osd/PGLog.cc: 732: FAILED assert(log.log.si…
…ze() == log_keys_debug.size())

Reviewed-by: Loic Dachary <ldachary@redhat.com>
@ghost

This comment has been minimized.

ghost commented Oct 20, 2015

@liewegas does this backport look good to merge ? It passed a run of the firefly rados suite ( see http://tracker.ceph.com/issues/11644#note-110 ). Note that there was a valgrind issues but it is unrelated and fixed by #6325.

@liewegas

This comment has been minimized.

Member

liewegas commented Oct 20, 2015

👍

ghost pushed a commit that referenced this pull request Oct 20, 2015

Loic Dachary
Merge pull request #5820 from SUSE/wip-12845-firefly
osd/PGLog.cc: 732: FAILED assert(log.log.size() == log_keys_debug.size())

Reviewed-by: Sage Weil <sage@redhat.com>

@ghost ghost merged commit e771054 into ceph:firefly Oct 20, 2015

@smithfarm smithfarm deleted the SUSE:wip-12845-firefly branch Oct 20, 2015

@ghost ghost changed the title from osd/PGLog.cc: 732: FAILED assert(log.log.size() == log_keys_debug.size()) to osd: osd/PGLog.cc: 732: FAILED assert(log.log.size() == log_keys_debug.size()) Oct 24, 2015

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment