Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw/rgw_admin: Checking the legality of the parameters #5879

Merged
merged 1 commit into from Oct 28, 2015

Conversation

Projects
None yet
3 participants
@qiankunzheng
Copy link
Contributor

commented Sep 11, 2015

There is no messages When some parameters are invalid. so the Program should be added the function which checks parameters, if the parameters are invalid, the program will give some messages.

Fixes: #13018
Signed-off-by: Qiankun Zheng zheng.qiankun@h3c.com

@qiankunzheng

This comment has been minimized.

Copy link
Contributor Author

commented Sep 15, 2015

@yehudasa
hi, when can be reviewed this fix ? thank you very much

@qiankunzheng

This comment has been minimized.

Copy link
Contributor Author

commented Sep 21, 2015

@yehudasa
hi, the bug has been fixed, can you review it when you aren't too busy ? thank you very much

@yehudasa

This comment has been minimized.

Copy link
Member

commented Sep 21, 2015

@qiankunzheng it looks good to me. Not sure why the build bot didn't kick in though (@dachary ?)

rgw/rgw_admin: Checking the legality of the params
There is no messages When some params are invalid. so the Program should be added the function which checks params, if the params are invalid, the program will give some messages.

Fixes: #13018
Signed-off-by: Qiankun Zheng <zheng.qiankun@h3c.com>
@qiankunzheng

This comment has been minimized.

Copy link
Contributor Author

commented Sep 26, 2015

@yehudasa
hi, This fix has been compiled successfully by the build bot, when can be reviewed this fix ? Many thanks.

@qiankunzheng

This comment has been minimized.

Copy link
Contributor Author

commented Oct 8, 2015

@yehudasa
hi, What do you need me to do about this fix? Many thanks.

@ghost ghost added the rgw label Oct 16, 2015

@qiankunzheng

This comment has been minimized.

Copy link
Contributor Author

commented Oct 20, 2015

@yehudasa,@dachary
hi, the bug has been fixed, when can this fix be reviewed and merged? thank you very much

@qiankunzheng

This comment has been minimized.

Copy link
Contributor Author

commented Oct 28, 2015

@yehudasa
hi, when can be reviewed this fix ? thank you very much

yehudasa added a commit that referenced this pull request Oct 28, 2015

Merge pull request #5879 from H3C/wip-rgw-bugfix1
rgw/rgw_admin: Checking the legality of the parameters

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>

@yehudasa yehudasa merged commit 9b013d0 into ceph:master Oct 28, 2015

@qiankunzheng qiankunzheng deleted the H3C:wip-rgw-bugfix1 branch Nov 26, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.