Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd: copy-from doesn't preserve truncate_{seq,size} #5885

Merged
merged 1 commit into from Oct 8, 2015

Conversation

Projects
None yet
4 participants
@Abhishekvrshny
Copy link
Contributor

Abhishekvrshny commented Sep 11, 2015

ReplicatedPG,Objecter: copy_get should include truncate_seq and size
Otherwise, we break CephFS over cache tiers.

Fixes: #12551
Signed-off-by: Samuel Just <sjust@redhat.com>
(cherry picked from commit 6f9ee79)

Conflicts:
	src/osd/ReplicatedPG.cc

@liewegas liewegas added this to the hammer milestone Sep 11, 2015

@Abhishekvrshny Abhishekvrshny assigned ghost Sep 12, 2015

ghost pushed a commit that referenced this pull request Oct 2, 2015

Merge pull request #5885: osd: copy-from doesn't preserve truncate_{s…
…eq,size}

Reviewed-by: Loic Dachary <ldachary@redhat.com>

ghost pushed a commit that referenced this pull request Oct 3, 2015

Merge pull request #5885: osd: copy-from doesn't preserve truncate_{s…
…eq,size}

Reviewed-by: Loic Dachary <ldachary@redhat.com>

ghost pushed a commit that referenced this pull request Oct 3, 2015

Merge pull request #5885: osd: copy-from doesn't preserve truncate_{s…
…eq,size}

Reviewed-by: Loic Dachary <ldachary@redhat.com>

ghost pushed a commit that referenced this pull request Oct 3, 2015

Merge pull request #5885: osd: copy-from doesn't preserve truncate_{s…
…eq,size}

Reviewed-by: Loic Dachary <ldachary@redhat.com>

ghost pushed a commit that referenced this pull request Oct 7, 2015

Merge pull request #5885: osd: copy-from doesn't preserve truncate_{s…
…eq,size}

Reviewed-by: Loic Dachary <ldachary@redhat.com>

ghost pushed a commit that referenced this pull request Oct 8, 2015

Merge pull request #5885: osd: copy-from doesn't preserve truncate_{s…
…eq,size}

Reviewed-by: Loic Dachary <ldachary@redhat.com>

liewegas added a commit that referenced this pull request Oct 8, 2015

Merge pull request #5885 from Abhishekvrshny/wip-13034-hammer
osd: copy-from doesn't preserve truncate_{seq,size}

Reviewed-by: Sage Weil <sage@redhat.com>

@liewegas liewegas merged commit 629b631 into ceph:hammer Oct 8, 2015

@liewegas

This comment has been minimized.

Copy link
Member

liewegas commented Oct 8, 2015

This is causing corruption for cephfs users... putting it in 0.94.4

@gregsfortytwo @athanatos

@ghost

This comment has been minimized.

Copy link

ghost commented Oct 8, 2015

it passed the fs suite as part of http://tracker.ceph.com/issues/13356#note-4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.