Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: Pipe: Drop connect_seq increase line #5908

Merged
1 commit merged into from Sep 14, 2015

Conversation

Projects
None yet
4 participants
@liewegas
Copy link
Member

liewegas commented Sep 13, 2015

Pipe: Drop connect_seq increase line
Revert commit 0fc47e2.

When accepting and "connect.connect_seq == existing->connect_seq",
existing->state maybe STATE_OPEN, STATE_STANDBY or STANDY_CONNECTING.
This commit only fix partial problem and want to assert
"(existing->state == STATE_CONNECTING)".

So later we added codes to catch
"(existing->state == STATE_OPEN || existing->state == STATE_STANDBY)"
before asserting.

Backport: dumpling, firefly, giant

Signed-off-by: Haomai Wang <haomaiwang@gmail.com>
(cherry picked from commit 67225cb)

@liewegas liewegas added this to the hammer milestone Sep 13, 2015

@liewegas

This comment has been minimized.

Copy link
Member Author

liewegas commented Sep 13, 2015

I'm hoping this is responsible for the ping failures i'm seeing on hammer->infernalis upgrade tests

@gregsfortytwo

This comment has been minimized.

Copy link
Member

gregsfortytwo commented Sep 14, 2015

LGTM @liewegas, @dachary.

ghost pushed a commit that referenced this pull request Sep 14, 2015

Loic Dachary
Merge pull request #5908 from liewegas/wip-simple-connect-hammer
Pipe: Drop connect_seq increase line

Reviewed-by: Greg Farnum <gfarnum@redhat.com>

@ghost ghost merged commit 0022c03 into ceph:hammer Sep 14, 2015

@ghost

This comment has been minimized.

Copy link

ghost commented Sep 14, 2015

Is there an issue associated with this problem ?

@ghost ghost changed the title Pipe: Drop connect_seq increase line common: Pipe: Drop connect_seq increase line Sep 14, 2015

@ghost ghost self-assigned this Sep 14, 2015

@gregsfortytwo

This comment has been minimized.

Copy link
Member

gregsfortytwo commented Sep 14, 2015

Searching my email the answer seems to be "no", sorry. :/

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.