Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rhel 5.9 librados compile fix, moved blkid to RBD check/compilation #5954

Merged
merged 1 commit into from Oct 24, 2015

Conversation

Projects
None yet
4 participants
@rohanmars
Copy link
Contributor

rohanmars commented Sep 17, 2015

Signed-off-by: Rohan Mars code@rohanmars.com

@smithfarm

This comment has been minimized.

Copy link
Contributor

smithfarm commented Sep 19, 2015

@dachary Is this bot failure real or bogus?

@smithfarm

This comment has been minimized.

Copy link
Contributor

smithfarm commented Sep 19, 2015

@rohanmars Can you describe the bug this commit is fixing? Best would be at http://tracker.ceph.com/projects/devops/issues/new . . . that will also help with backporting. Thanks!

@ghost

This comment has been minimized.

Copy link

ghost commented Sep 20, 2015

@smithfarm it's a false negative indeed http://tracker.ceph.com/issues/13176

@rohanmars

This comment has been minimized.

Copy link
Contributor Author

rohanmars commented Sep 20, 2015

@smithfarm

This comment has been minimized.

Copy link
Contributor

smithfarm commented Sep 20, 2015

@rohanmars Thanks. Now, if you could do git commit --amend and add a line to the commit message: Fixes: #13177 that would be really nice. (After you amend the commit message, force-push your wip branch and the pull request will be updated.)

@rohanmars rohanmars force-pushed the rohanmars:wip-rhel59-fixes branch from df869de to 937e4f8 Sep 20, 2015

@rohanmars

This comment has been minimized.

Copy link
Contributor Author

rohanmars commented Sep 20, 2015

@smithfarm, done as requested. Thanks.

@ghost

This comment has been minimized.

Copy link

ghost commented Sep 20, 2015

Please ignore the make check bot, it is a false negative: http://tracker.ceph.com/issues/13182

@liewegas

This comment has been minimized.

Copy link
Member

liewegas commented Oct 18, 2015

looks fine to me. just need to build test..

liewegas added a commit that referenced this pull request Oct 24, 2015

Merge pull request #5954 from rohanmars/wip-rhel59-fixes
rhel 5.9 librados compile fix, moved blkid to RBD check/compilation

Reviewed-by: Sage Weil <sage@redhat.com>

@liewegas liewegas merged commit 09d0c8a into ceph:master Oct 24, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.