New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd: PG::handle_advance_map: on_pool_change after handling the map change #5988

Merged
1 commit merged into from Oct 20, 2015

Conversation

Projects
None yet
4 participants
@smithfarm
Contributor

smithfarm commented Sep 19, 2015

http://tracker.ceph.com/issues/13038

Otherwise, the is_active() checks in the hitset code can erroneously
return true firing off repops stamped with the new epoch which then get
cleared in the map change code. The filestore callbacks then pass the
interval check and call into a destroyed repop structure.

Fixes: 12809
Backport: hammer,firefly
Signed-off-by: Samuel Just sjust@redhat.com
(cherry picked from commit 14e02bc)

PG::handle_advance_map: on_pool_change after handling the map change
Otherwise, the is_active() checks in the hitset code can erroneously
return true firing off repops stamped with the new epoch which then get
cleared in the map change code.  The filestore callbacks then pass the
interval check and call into a destroyed repop structure.

Fixes: 12809
Backport: hammer,firefly
Signed-off-by: Samuel Just <sjust@redhat.com>
(cherry picked from commit 14e02bc)

@smithfarm smithfarm added this to the firefly milestone Sep 19, 2015

@smithfarm smithfarm self-assigned this Sep 19, 2015

ghost pushed a commit that referenced this pull request Oct 20, 2015

Merge pull request #5988: PG::handle_advance_map: on_pool_change afte…
…r handling the map change

Reviewed-by: Loic Dachary <ldachary@redhat.com>
@ghost

This comment has been minimized.

ghost commented Oct 20, 2015

@liewegas does this backport look good to merge ? It passed a run of the firefly rados suite ( see http://tracker.ceph.com/issues/11644#note-110 ). Note that there was a valgrind issues but it is unrelated and fixed by #6325.

@liewegas

This comment has been minimized.

Member

liewegas commented Oct 20, 2015

👍

ghost pushed a commit that referenced this pull request Oct 20, 2015

Loic Dachary
Merge pull request #5988 from SUSE/wip-13038-firefly
PG::handle_advance_map: on_pool_change after handling the map change

Reviewed-by: Sage Weil <sage@redhat.com>

@ghost ghost merged commit a3823fe into ceph:firefly Oct 20, 2015

@smithfarm smithfarm deleted the SUSE:wip-13038-firefly branch Oct 20, 2015

@ghost ghost changed the title from PG::handle_advance_map: on_pool_change after handling the map change to osd: PG::handle_advance_map: on_pool_change after handling the map change Oct 24, 2015

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment