New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: ThreadPool add/remove work queue methods not thread safe #5991

Merged
1 commit merged into from Oct 20, 2015

Conversation

Projects
None yet
5 participants
@smithfarm
Contributor

smithfarm commented Sep 19, 2015

WorkQueue: add/remove_work_queue methods now thread safe
These methods were not acquiring the ThreadPool lock when
manipulating the work_queue collection.  This was causing
occasional crashes within librbd when opening and closing
images.

Fixes: #12662
Backport: hammer, firefly
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit 3e18449)

@smithfarm smithfarm self-assigned this Sep 19, 2015

@smithfarm smithfarm added this to the firefly milestone Sep 19, 2015

@smithfarm smithfarm added bug fix core common and removed core labels Sep 19, 2015

ghost pushed a commit that referenced this pull request Oct 20, 2015

Merge pull request #5991: ThreadPool add/remove work queue methods no…
…t thread safe

Reviewed-by: Loic Dachary <ldachary@redhat.com>
@ghost

This comment has been minimized.

ghost commented Oct 20, 2015

@jdurgin does this backport look good to merge ? It passed a run of the firefly rados suite ( see http://tracker.ceph.com/issues/11644#note-110 ). Note that there was a valgrind issues but it is unrelated and fixed by #6325.

@jdurgin

This comment has been minimized.

Member

jdurgin commented Oct 20, 2015

👍

ghost pushed a commit that referenced this pull request Oct 20, 2015

Loic Dachary
Merge pull request #5991 from SUSE/wip-13043-firefly
ThreadPool add/remove work queue methods not thread safe

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

@ghost ghost merged commit 77a1b5f into ceph:firefly Oct 20, 2015

@smithfarm smithfarm deleted the SUSE:wip-13043-firefly branch Oct 20, 2015

@ghost ghost changed the title from ThreadPool add/remove work queue methods not thread safe to common: ThreadPool add/remove work queue methods not thread safe Oct 24, 2015

@funny-falcon

This comment has been minimized.

funny-falcon commented Jun 7, 2016

Did it affected librados?

@funny-falcon

This comment has been minimized.

funny-falcon commented Jun 9, 2016

I repeat my question:

  • were it safe to use single rados_ioctx_t from multiple threads before this fix ?
@smithfarm

This comment has been minimized.

Contributor

smithfarm commented Jun 9, 2016

@funny-falcon I suggest you ask this question on the ceph-devel mailing list [1]. Here in this backport PR you're probably not reaching the right people.

[1] http://ceph.com/resources/mailing-list-irc/

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment