New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mon: increase globalid default for firefly #6010

Merged
2 commits merged into from Oct 20, 2015

Conversation

Projects
None yet
3 participants
@liewegas
Member

liewegas commented Sep 21, 2015

This helps a lot with mon responsiveness

Backport: http://tracker.ceph.com/issues/13255

liewegas added some commits Jan 18, 2015

mon: change mon_globalid_prealloc to 10000 (from 100)
100 ids (session 100 authentications) can be consumed quite quickly if
the monitor is being queried by the CLI via scripts or on a large cluster,
especially if the propose interval is long (many seconds).  These live in
a 64-bit value and are only "lost" if we have a mon election before they
are consumed, so there's no real risk here.

Backport: giant, firefly
Reviewed-by: Joao Eduardo Luis <joao@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit 1d1215f)
mon: handle case where mon_globalid_prealloc > max_global_id
This triggers with the new larger mon_globalid_prealloc value.  It didn't
trigger on the existing cluster I tested on because it already had a very
large max.

Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit bbaf582)

@liewegas liewegas added this to the firefly milestone Sep 21, 2015

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Sep 23, 2015

lgtm

ghost pushed a commit that referenced this pull request Oct 20, 2015

Merge pull request #6010: increase globalid default for firefly
Reviewed-by: Loic Dachary <ldachary@redhat.com>

@ghost ghost assigned tchaikov Oct 20, 2015

ghost pushed a commit that referenced this pull request Oct 20, 2015

Loic Dachary
Merge pull request #6010 from liewegas/wip-globalid-firefly
increase globalid default for firefly

Reviewed-by: Kefu Chai <kchai@redhat.com>

@ghost ghost merged commit 8fd4dd7 into ceph:firefly Oct 20, 2015

@ghost ghost changed the title from increase globalid default for firefly to mon: increase globalid default for firefly Oct 24, 2015

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment