New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: HeartBeat: include types #6038

Merged
merged 1 commit into from Sep 23, 2015

Conversation

Projects
None yet
3 participants
@liewegas
Member

liewegas commented Sep 22, 2015

Fixes atomic_t build issue without libatomic-ops.

Fixes: #13088
Signed-off-by: Sage Weil sage@redhat.com

@tchaikov tchaikov added this to the firefly milestone Sep 23, 2015

@tchaikov tchaikov added the build/ops label Sep 23, 2015

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Sep 23, 2015

lgtm. but to avoid polluting the users of RWLock.h, probably we need to change RWLock.h instead of the source files which include it..

common/RWLock: include assert
Fixes atomic_t build issue without libatomic-ops.

Fixes: #13088
Signed-off-by: Sage Weil <sage@redhat.com>

liewegas added a commit that referenced this pull request Sep 23, 2015

Merge pull request #6038 from liewegas/wip-13088
common/HeartBeat: include types

Reviewed-by: Kefu Chai <kchai@redhat.com>

@liewegas liewegas merged commit ecabc67 into ceph:firefly Sep 23, 2015

@liewegas liewegas deleted the liewegas:wip-13088 branch Sep 23, 2015

@ghost ghost changed the title from common/HeartBeat: include types to common: HeartBeat: include types Oct 24, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment