New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: don't preserve acls when copying object #6039

Merged
merged 3 commits into from Oct 12, 2015

Conversation

Projects
None yet
2 participants
@yehudasa
Member

yehudasa commented Sep 22, 2015

Fixes for the following issues:

issue 11563 (http://tracker.ceph.com/issues/12199)
issue 12370 (http://tracker.ceph.com/issues/12852)
issue 13015 (http://tracker.ceph.com/issues/13019)

rgw: fix assignment of copy obj attributes
Fixes: #11563
Clarify the confusing usage of set_copy_attrs() by switching the source and
destinatiion params (attrs, src_attrs). Switch to use attrs instead of
src_attrs afterwards. In one of the cases we originally used the wrong
variable.

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>
(cherry picked from commit e41d97c)

@yehudasa yehudasa added this to the hammer milestone Sep 22, 2015

yehudasa added some commits Aug 13, 2015

rgw: don't preserve acls when copying object
Fixes: #12370

When copying an object we need to use the acls we calculated earlier,
and not the source acls.
This was broken at e41d97c.

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>
(cherry picked from commit fb02024)
rgw: preserve all attrs if intra-zone copy
Fixes: #13015
Intra zone copy requires that all objects' attributes are preserved.

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

@ghost ghost self-assigned this Sep 22, 2015

@ghost ghost changed the title from Wip 13015 hammer to rgw: don't preserve acls when copying object Sep 22, 2015

ghost pushed a commit that referenced this pull request Oct 2, 2015

Merge pull request #6039: rgw: don't preserve acls when copying object
Reviewed-by: Loic Dachary <ldachary@redhat.com>

ghost pushed a commit that referenced this pull request Oct 3, 2015

Merge pull request #6039: rgw: don't preserve acls when copying object
Reviewed-by: Loic Dachary <ldachary@redhat.com>

ghost pushed a commit that referenced this pull request Oct 3, 2015

Merge pull request #6039: rgw: don't preserve acls when copying object
Reviewed-by: Loic Dachary <ldachary@redhat.com>

ghost pushed a commit that referenced this pull request Oct 3, 2015

Merge pull request #6039: rgw: don't preserve acls when copying object
Reviewed-by: Loic Dachary <ldachary@redhat.com>

ghost pushed a commit that referenced this pull request Oct 7, 2015

Merge pull request #6039: rgw: don't preserve acls when copying object
Reviewed-by: Loic Dachary <ldachary@redhat.com>

ghost pushed a commit that referenced this pull request Oct 8, 2015

Merge pull request #6039: rgw: don't preserve acls when copying object
Reviewed-by: Loic Dachary <ldachary@redhat.com>
@ghost

This comment has been minimized.

ghost commented Oct 10, 2015

@yehudasa does this backport look good to merge ? It passed a run of the hammer rgw suite ( see http://tracker.ceph.com/issues/13356#note-5 for details ).

yehudasa added a commit that referenced this pull request Oct 12, 2015

Merge pull request #6039 from ceph/wip-13015-hammer
rgw: don't preserve acls when copying object

@yehudasa yehudasa merged commit aa74de9 into hammer Oct 12, 2015

@yehudasa yehudasa deleted the wip-13015-hammer branch Oct 20, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment